Meishin/LoginSystem
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Improve security of Console and Log files (#1461)

Browse Source 
* Finally kill removePassword option

* Cleanup

* Cleanup

* Cleanup

* Cleanup

* Final Cleanup

* Fix compile warning

* Revert "Cleanup"
This commit is contained in:
Maxetto 2017-12-27 13:05:06 +01:00 committed by ljacqu
parent c1f3fcd393
commit 0a7e57b6a7
5 changed files with 0 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/config.md
View File

@ -433,8 +433,6 @@ Security:
# AuthMe will automatically disable and the server won't be protected! # AuthMe will automatically disable and the server won't be protected!
stopServer: true stopServer: true
console: console:
# Remove passwords from console?
removePassword: true
# Copy AuthMe log output in a separate file as well? # Copy AuthMe log output in a separate file as well?
logConsole: true logConsole: true
captcha: captcha:

2
samples/NewConfig.yml
View File

@ -473,8 +473,6 @@ Security:
console: console:
# Remove spam console # Remove spam console
noConsoleSpam: false noConsoleSpam: false
# Replace passwords in the console when player type a command like /login
removePassword: true
captcha: captcha:
# Player need to put a captcha when he fails too lot the password # Player need to put a captcha when he fails too lot the password
useCaptcha: false useCaptcha: false

4
src/main/java/fr/xephi/authme/initialization/OnStartupTasks.java
View File

@ -12,7 +12,6 @@ import fr.xephi.authme.settings.Settings;
import fr.xephi.authme.settings.properties.DatabaseSettings; import fr.xephi.authme.settings.properties.DatabaseSettings;
import fr.xephi.authme.settings.properties.EmailSettings; import fr.xephi.authme.settings.properties.EmailSettings;
import fr.xephi.authme.settings.properties.PluginSettings; import fr.xephi.authme.settings.properties.PluginSettings;
import fr.xephi.authme.settings.properties.SecuritySettings;
import org.apache.logging.log4j.LogManager; import org.apache.logging.log4j.LogManager;
import org.bstats.bukkit.Metrics; import org.bstats.bukkit.Metrics;
import org.bukkit.Bukkit; import org.bukkit.Bukkit;
@ -63,9 +62,6 @@ public class OnStartupTasks {
* @param logger the plugin logger * @param logger the plugin logger
*/ */
public static void setupConsoleFilter(Settings settings, Logger logger) { public static void setupConsoleFilter(Settings settings, Logger logger) {
if (!settings.getProperty(SecuritySettings.REMOVE_PASSWORD_FROM_CONSOLE)) {
return;
}
// Try to set the log4j filter // Try to set the log4j filter
try { try {
Class.forName("org.apache.logging.log4j.core.filter.AbstractFilter"); Class.forName("org.apache.logging.log4j.core.filter.AbstractFilter");

4
src/main/java/fr/xephi/authme/settings/properties/SecuritySettings.java
View File

@ -20,10 +20,6 @@ public final class SecuritySettings implements SettingsHolder {
public static final Property<Boolean> STOP_SERVER_ON_PROBLEM = public static final Property<Boolean> STOP_SERVER_ON_PROBLEM =
newProperty("Security.SQLProblem.stopServer", true); newProperty("Security.SQLProblem.stopServer", true);
@Comment("Remove passwords from console?")
public static final Property<Boolean> REMOVE_PASSWORD_FROM_CONSOLE =
newProperty("Security.console.removePassword", true);
@Comment("Copy AuthMe log output in a separate file as well?") @Comment("Copy AuthMe log output in a separate file as well?")
public static final Property<Boolean> USE_LOGGING = public static final Property<Boolean> USE_LOGGING =
newProperty("Security.console.logConsole", true); newProperty("Security.console.logConsole", true);

2
src/test/resources/fr/xephi/authme/config.test.yml
View File

@ -275,8 +275,6 @@ Security:
console: console:
# Remove spam console # Remove spam console
noConsoleSpam: false noConsoleSpam: false
# Replace passwords in the console when player type a command like /login
removePassword: true
# Copy AuthMe log output in a separate file as well? # Copy AuthMe log output in a separate file as well?
logConsole: true logConsole: true
captcha: captcha: