- Old SQLite setups have the last IP column as NOT NULL but without a default value. With the new concept (where we don't set a last IP on player registration) it fails. - Create an /authme debug child that allows to migrate SQLite (tricky because SQLite does not support dropping or modifying columns) - Allow last IP column to be NOT NULL in MySQL as well (extend MySQL /authme debug child) - Add TODO comments with follow-up issue to extend our commands with new registration IP field
This commit is contained in:
@@ -18,12 +18,16 @@ public class PlayerAuthTest {
|
||||
PlayerAuth auth = PlayerAuth.builder()
|
||||
.name("Bobby")
|
||||
.lastLogin(0L)
|
||||
.lastIp("127.0.0.1")
|
||||
.email("your@email.com")
|
||||
.build();
|
||||
|
||||
// then
|
||||
assertThat(auth.getNickname(), equalTo("bobby"));
|
||||
assertThat(auth.getLastLogin(), nullValue());
|
||||
// Note ljacqu 20171020: Although 127.0.0.1 is the default value, we need to keep it because it might
|
||||
// legitimately be the resolved IP of a player
|
||||
assertThat(auth.getLastIp(), equalTo("127.0.0.1"));
|
||||
assertThat(auth.getEmail(), nullValue());
|
||||
}
|
||||
|
||||
@@ -50,6 +54,7 @@ public class PlayerAuthTest {
|
||||
.name("Charlie")
|
||||
.email(null)
|
||||
.lastLogin(null)
|
||||
.lastIp(null)
|
||||
.groupId(19)
|
||||
.locPitch(123.004f)
|
||||
.build();
|
||||
@@ -57,6 +62,7 @@ public class PlayerAuthTest {
|
||||
// then
|
||||
assertThat(auth.getEmail(), nullValue());
|
||||
assertThat(auth.getLastLogin(), nullValue());
|
||||
assertThat(auth.getLastIp(), nullValue());
|
||||
assertThat(auth.getGroupId(), equalTo(19));
|
||||
assertThat(auth.getPitch(), equalTo(123.004f));
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user