Meishin/LoginSystem
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

#829 Move CommandSender / name to first argument to avoid confusion with varargs

Browse Source 
- Overloaded method with (String, String...) as args was problematic as it could be confusing on its own and also confusing with the (CommandSender, String...) flavor
This commit is contained in:
ljacqu
2018-03-10 16:58:30 +01:00
parent 7a3e2e9f71
commit 1a53cd11b2
17 changed files with 42 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/test/java/fr/xephi/authme/message/MessagesIntegrationTest.java
+3 -3
View File
@@ -100,7 +100,7 @@ public class MessagesIntegrationTest {
given(sender.getName()).willReturn("Tester");
// when
String message = messages.retrieveSingle(key, sender);
String message = messages.retrieveSingle(sender, key);
// then
assertThat(message, equalTo("We've got\nnew lines\nand ' apostrophes"));
@@ -252,7 +252,7 @@ public class MessagesIntegrationTest {
given(sender.getName()).willReturn("Tester");
// when
String message = messages.retrieveSingle(key, sender);
String message = messages.retrieveSingle(sender, key);
// then
assertThat(message, equalTo("§cWrong password!"));
@@ -266,7 +266,7 @@ public class MessagesIntegrationTest {
given(sender.getName()).willReturn("Tester");
// when
String result = messages.retrieveSingle(key, sender.getName(), "24680");
String result = messages.retrieveSingle(sender.getName(), key, "24680");
// then
assertThat(result, equalTo("Use /captcha 24680 to solve the captcha"));