#930 Extract common captcha functionality into abstract superclass

- Create AbstractCaptchaManager
- Add tests

src/test/java/fr/xephi/authme/data/LoginCaptchaManagerTest.java

@@ -51,8 +51,8 @@ public class LoginCaptchaManagerTest {
         assertThat(captchaCode.length(), equalTo(4));
         assertThat(badResult, equalTo(false));
         assertThat(goodResult, equalTo(true));
-        // Supplying correct code should clear the entry, and any code should be valid if no entry is present
-        assertThat(manager.checkCode(player, "bogus"), equalTo(true));
+        // Supplying correct code should clear the entry, and a code should be invalid if no entry is present
+        assertThat(manager.checkCode(player, "bogus"), equalTo(false));
     }
 
     @Test

src/test/java/fr/xephi/authme/data/RegistrationCaptchaManagerTest.java

@@ -0,0 +1,82 @@
+package fr.xephi.authme.data;
+
+import fr.xephi.authme.ReflectionTestUtils;
+import fr.xephi.authme.settings.Settings;
+import fr.xephi.authme.settings.properties.SecuritySettings;
+import fr.xephi.authme.util.expiring.ExpiringMap;
+import org.junit.Test;
+
+import static fr.xephi.authme.AuthMeMatchers.stringWithLength;
+import static org.hamcrest.Matchers.equalTo;
+import static org.junit.Assert.assertThat;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Mockito.mock;
+
+/**
+ * Test for {@link RegistrationCaptchaManager}.
+ */
+public class RegistrationCaptchaManagerTest {
+
+    @Test
+    public void shouldBeDisabled() {
+        // given
+        Settings settings = mock(Settings.class);
+        // Return false first time, and true after that
+        given(settings.getProperty(SecuritySettings.ENABLE_CAPTCHA_FOR_REGISTRATION))
+            .willReturn(false).willReturn(true);
+        given(settings.getProperty(SecuritySettings.CAPTCHA_LENGTH)).willReturn(12);
+
+        // when
+        RegistrationCaptchaManager captchaManager1 = new RegistrationCaptchaManager(settings);
+        RegistrationCaptchaManager captchaManager2 = new RegistrationCaptchaManager(settings);
+
+        // then
+        assertThat(captchaManager1.isCaptchaRequired("bob"), equalTo(false));
+        assertThat(captchaManager2.isCaptchaRequired("bob"), equalTo(true));
+    }
+
+    @Test
+    public void shouldVerifyCodeSuccessfully() {
+        // given
+        Settings settings = mock(Settings.class);
+        given(settings.getProperty(SecuritySettings.ENABLE_CAPTCHA_FOR_REGISTRATION)).willReturn(true);
+        given(settings.getProperty(SecuritySettings.CAPTCHA_LENGTH)).willReturn(12);
+
+        String captcha = "abc3";
+        RegistrationCaptchaManager captchaManager = new RegistrationCaptchaManager(settings);
+        getCodeMap(captchaManager).put("test", captcha);
+
+        // when
+        boolean isSuccessful = captchaManager.checkCode("TeSt", captcha);
+
+        // then
+        assertThat(isSuccessful, equalTo(true));
+        assertThat(getCodeMap(captchaManager).isEmpty(), equalTo(true));
+        assertThat(captchaManager.isCaptchaRequired("test"), equalTo(false));
+    }
+
+    @Test
+    public void shouldGenerateAndRetrieveCode() {
+        // given
+        Settings settings = mock(Settings.class);
+        given(settings.getProperty(SecuritySettings.ENABLE_CAPTCHA_FOR_REGISTRATION)).willReturn(true);
+        int captchaLength = 9;
+        given(settings.getProperty(SecuritySettings.CAPTCHA_LENGTH)).willReturn(captchaLength);
+        RegistrationCaptchaManager captchaManager = new RegistrationCaptchaManager(settings);
+
+        // when
+        String captcha1 = captchaManager.getCaptchaCodeOrGenerateNew("toast");
+        String captcha2 = captchaManager.getCaptchaCodeOrGenerateNew("Toast");
+
+        // then
+        assertThat(captcha1, equalTo(captcha2));
+        assertThat(captcha1, stringWithLength(captchaLength));
+
+        // when (2) / then (2)
+        assertThat(captchaManager.checkCode("toast", captcha1), equalTo(true));
+    }
+
+    private static ExpiringMap<String, String> getCodeMap(AbstractCaptchaManager captchaManager) {
+        return ReflectionTestUtils.getFieldValue(AbstractCaptchaManager.class, captchaManager, "captchaCodes");
+    }
+}