#792 #814 Create command to remove NOT NULL constraints

- Create command under /authme debug that allows to change the 'nullable' status of MySQL columns (currently last date and email only)
   - We need to offer a default value for forum integrations that have a NOT NULL email column. Offering a command avoids us from force-migrating existing databases while still offering migrations in both directions
- Change in default value handling: lack of values are not handled by setting default values to the PlayerAuth anymore, and reading a default value from the database into a PlayerAuth will be translated into null by the PlayerAuth builder
- When a new database is created, email and lastlogin are now nullable and lack a default a value

Open points:
- Finish MySqlDefaultChangerTest
- Revise purging logic (#792)
- Allow to have more columns nullable (#814)

src/main/java/fr/xephi/authme/datasource/FlatFile.java

@@ -394,7 +394,7 @@ public class FlatFile implements DataSource {
                 .name(args[0]).realName(args[0]).password(args[1], null);
 
             if (args.length >= 3)   builder.lastIp(args[2]);
-            if (args.length >= 4)   builder.lastLogin(Long.parseLong(args[3]));
+            if (args.length >= 4)   builder.lastLogin(parseNullableLong(args[3]));
             if (args.length >= 7) {
                 builder.locX(Double.parseDouble(args[4]))
                     .locY(Double.parseDouble(args[5]))
@@ -406,4 +406,8 @@ public class FlatFile implements DataSource {
         }
         return null;
     }
+
+    private static Long parseNullableLong(String str) {
+        return "null".equals(str) ? null : Long.parseLong(str);
+    }
 }

src/main/java/fr/xephi/authme/datasource/MySQL.java

@@ -27,6 +27,7 @@ import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
 
+import static fr.xephi.authme.datasource.SqlDataSourceUtils.getNullableLong;
 import static fr.xephi.authme.datasource.SqlDataSourceUtils.logSqlException;
 
 public class MySQL implements DataSource {
@@ -196,14 +197,14 @@ public class MySQL implements DataSource {
 
             if (isColumnMissing(md, col.LAST_LOGIN)) {
                 st.executeUpdate("ALTER TABLE " + tableName
-                    + " ADD COLUMN " + col.LAST_LOGIN + " BIGINT NOT NULL DEFAULT 0;");
+                    + " ADD COLUMN " + col.LAST_LOGIN + " BIGINT;");
             } else {
                 migrateLastLoginColumn(con, md);
             }
 
             if (isColumnMissing(md, col.REGISTRATION_DATE)) {
                 st.executeUpdate("ALTER TABLE " + tableName
-                    + " ADD COLUMN " + col.REGISTRATION_DATE + " BIGINT;");
+                    + " ADD COLUMN " + col.REGISTRATION_DATE + " BIGINT NOT NULL;");
             }
 
             if (isColumnMissing(md, col.REGISTRATION_IP)) {
@@ -240,7 +241,7 @@ public class MySQL implements DataSource {
 
             if (isColumnMissing(md, col.EMAIL)) {
                 st.executeUpdate("ALTER TABLE " + tableName + " ADD COLUMN "
-                    + col.EMAIL + " VARCHAR(255) DEFAULT 'your@email.com' AFTER " + col.LASTLOC_WORLD);
+                    + col.EMAIL + " VARCHAR(255);");
             }
 
             if (isColumnMissing(md, col.IS_LOGGED)) {
@@ -394,7 +395,7 @@ public class MySQL implements DataSource {
             + col.LAST_IP + "=?, " + col.LAST_LOGIN + "=?, " + col.REAL_NAME + "=? WHERE " + col.NAME + "=?;";
         try (Connection con = getConnection(); PreparedStatement pst = con.prepareStatement(sql)) {
             pst.setString(1, auth.getLastIp());
-            pst.setLong(2, auth.getLastLogin());
+            pst.setObject(2, auth.getLastLogin());
             pst.setString(3, auth.getRealName());
             pst.setString(4, auth.getNickname());
             pst.executeUpdate();
@@ -673,7 +674,7 @@ public class MySQL implements DataSource {
             .name(row.getString(col.NAME))
             .realName(row.getString(col.REAL_NAME))
             .password(row.getString(col.PASSWORD), salt)
-            .lastLogin(row.getLong(col.LAST_LOGIN))
+            .lastLogin(getNullableLong(row, col.LAST_LOGIN))
             .lastIp(row.getString(col.LAST_IP))
             .email(row.getString(col.EMAIL))
             .registrationDate(row.getLong(col.REGISTRATION_DATE))

src/main/java/fr/xephi/authme/datasource/SQLite.java

@@ -21,6 +21,7 @@ import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
 
+import static fr.xephi.authme.datasource.SqlDataSourceUtils.getNullableLong;
 import static fr.xephi.authme.datasource.SqlDataSourceUtils.logSqlException;
 
 /**
@@ -140,7 +141,7 @@ public class SQLite implements DataSource {
 
             if (isColumnMissing(md, col.EMAIL)) {
                 st.executeUpdate("ALTER TABLE " + tableName
-                    + " ADD COLUMN " + col.EMAIL + " VARCHAR(255) DEFAULT 'your@email.com';");
+                    + " ADD COLUMN " + col.EMAIL + " VARCHAR(255);");
             }
 
             if (isColumnMissing(md, col.IS_LOGGED)) {
@@ -295,7 +296,7 @@ public class SQLite implements DataSource {
             + col.REAL_NAME + "=? WHERE " + col.NAME + "=?;";
         try (PreparedStatement pst = con.prepareStatement(sql)){
             pst.setString(1, auth.getLastIp());
-            pst.setLong(2, auth.getLastLogin());
+            pst.setObject(2, auth.getLastLogin());
             pst.setString(3, auth.getRealName());
             pst.setString(4, auth.getNickname());
             pst.executeUpdate();
@@ -574,7 +575,7 @@ public class SQLite implements DataSource {
             .email(row.getString(col.EMAIL))
             .realName(row.getString(col.REAL_NAME))
             .password(row.getString(col.PASSWORD), salt)
-            .lastLogin(row.getLong(col.LAST_LOGIN))
+            .lastLogin(getNullableLong(row, col.LAST_LOGIN))
             .lastIp(row.getString(col.LAST_IP))
             .registrationDate(row.getLong(col.REGISTRATION_DATE))
             .registrationIp(row.getString(col.REGISTRATION_IP))