#603 Various setting improvements

- Pass PropertyMap to settings class from the outside
- Fix tests not being reentrant due to real file writes
- Improve Node (internal tree for PropertyMap) interface
- Add code coverage for private constructors

src/test/java/fr/xephi/authme/settings/properties/SettingsClassConsistencyTest.java

@@ -9,6 +9,7 @@ import org.junit.Test;
 import java.io.File;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Field;
+import java.lang.reflect.InvocationTargetException;
 import java.lang.reflect.Modifier;
 import java.util.ArrayList;
 import java.util.HashSet;
@@ -92,6 +93,17 @@ public class SettingsClassConsistencyTest {
                 constructors, arrayWithSize(1));
             assertThat("Constructor of " + clazz + " is private",
                 Modifier.isPrivate(constructors[0].getModifiers()), equalTo(true));
+
+            // Ugly hack to get coverage on the private constructors
+            // http://stackoverflow.com/questions/14077842/how-to-test-a-private-constructor-in-java-application
+            try {
+                Constructor<?> constructor = clazz.getDeclaredConstructor();
+                constructor.setAccessible(true);
+                constructor.newInstance();
+            } catch (NoSuchMethodException | InstantiationException
+                | IllegalAccessException | InvocationTargetException e) {
+                e.printStackTrace();
+            }
         }
     }
 

src/test/java/fr/xephi/authme/settings/properties/TestConfiguration.java

@@ -1,9 +1,13 @@
 package fr.xephi.authme.settings.properties;
 
+import fr.xephi.authme.ReflectionTestUtils;
 import fr.xephi.authme.settings.domain.Property;
 import fr.xephi.authme.settings.domain.PropertyType;
 import fr.xephi.authme.settings.domain.SettingsClass;
+import fr.xephi.authme.settings.propertymap.PropertyMap;
+import fr.xephi.authme.util.WrapperMock;
 
+import java.lang.reflect.Field;
 import java.util.List;
 
 import static fr.xephi.authme.settings.domain.Property.newProperty;
@@ -47,4 +51,23 @@ public final class TestConfiguration implements SettingsClass {
     private TestConfiguration() {
     }
 
+    /**
+     * Generate a property map with all properties in {@link TestConfiguration}.
+     *
+     * @return The generated property map
+     */
+    public static PropertyMap generatePropertyMap() {
+        WrapperMock.createInstance();
+        PropertyMap propertyMap = new PropertyMap();
+        for (Field field : TestConfiguration.class.getDeclaredFields()) {
+            Object fieldValue = ReflectionTestUtils.getFieldValue(TestConfiguration.class, null, field.getName());
+            if (fieldValue instanceof Property<?>) {
+                Property<?> property = (Property<?>) fieldValue;
+                String[] comments = new String[]{"Comment for '" + property.getPath() + "'"};
+                propertyMap.put(property, comments);
+            }
+        }
+        return propertyMap;
+    }
+
 }