Meishin/LoginSystem
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Minor code householding

Browse Source 
- Add removed property to migration service
- Log exception with appropriate logger method
This commit is contained in:
ljacqu 2016-06-01 23:24:48 +02:00
parent 1cbd11a753
commit 38db2ef0bd
3 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/java/fr/xephi/authme/ConsoleLogger.java
View File

@ -46,7 +46,7 @@ public final class ConsoleLogger {
try { try {
fileWriter = new FileWriter(logFile, true); fileWriter = new FileWriter(logFile, true);
} catch (IOException e) { } catch (IOException e) {
ConsoleLogger.showError("Failed to create the log file:" + e); ConsoleLogger.logException("Failed to create the log file:", e);
} }
} }
} else { } else {
@ -70,7 +70,7 @@ public final class ConsoleLogger {
public static void debug(String message) { public static void debug(String message) {
if (enableDebug) { if (enableDebug) {
//creating and filling an exception is a expensive call //creating and filling an exception is a expensive call
//->so it should be removed as soon #419 is fixed //TODO #419 20160601: ->so it should be removed as soon #419 is fixed
//logger.isLoggable does not work because the plugin logger is always ALL //logger.isLoggable does not work because the plugin logger is always ALL
logger.log(Level.FINE, message + ' ' + Thread.currentThread().getName(), new Exception()); logger.log(Level.FINE, message + ' ' + Thread.currentThread().getName(), new Exception());

3
src/main/java/fr/xephi/authme/command/CommandInitializer.java
View File

@ -43,9 +43,6 @@ import java.util.Collection;
import java.util.List; import java.util.List;
import java.util.Set; import java.util.Set;
import static fr.xephi.authme.permission.DefaultPermission.ALLOWED;
import static fr.xephi.authme.permission.DefaultPermission.OP_ONLY;
/** /**
* Initializes all available AuthMe commands. * Initializes all available AuthMe commands.
*/ */

2
src/main/java/fr/xephi/authme/settings/SettingsMigrationService.java
View File

@ -64,7 +64,7 @@ public class SettingsMigrationService {
String[] deprecatedProperties = { String[] deprecatedProperties = {
"Converter.Rakamak.newPasswordHash", "Hooks.chestshop", "Hooks.legacyChestshop", "Hooks.notifications", "Converter.Rakamak.newPasswordHash", "Hooks.chestshop", "Hooks.legacyChestshop", "Hooks.notifications",
"Passpartu", "Performances", "settings.restrictions.enablePasswordVerifier", "Xenoforo.predefinedSalt", "Passpartu", "Performances", "settings.restrictions.enablePasswordVerifier", "Xenoforo.predefinedSalt",
"VeryGames"}; "VeryGames", "settings.restrictions.allowAllCommandsIfRegistrationIsOptional"};
for (String deprecatedPath : deprecatedProperties) { for (String deprecatedPath : deprecatedProperties) {
if (configuration.contains(deprecatedPath)) { if (configuration.contains(deprecatedPath)) {
return true; return true;