#450 Create migration service for new settings

- Create service to check if new settings is up-to-date
- Remove up-to-date checks from old Settings
- Update tests

src/test/java/fr/xephi/authme/settings/ConfigFileConsistencyTest.java

@@ -1,7 +1,5 @@
 package fr.xephi.authme.settings;
 
-import fr.xephi.authme.ReflectionTestUtils;
-import fr.xephi.authme.settings.NewSetting;
 import fr.xephi.authme.settings.domain.Property;
 import fr.xephi.authme.settings.properties.SettingsFieldRetriever;
 import fr.xephi.authme.settings.propertymap.PropertyMap;
@@ -36,16 +34,14 @@ public class ConfigFileConsistencyTest {
         // given
         URL url = this.getClass().getResource(CONFIG_FILE);
         File configFile = new File(url.getFile());
-        NewSetting settings = new NewSetting(YamlConfiguration.loadConfiguration(configFile), new File("bogus"), null);
+        FileConfiguration configuration = YamlConfiguration.loadConfiguration(configFile);
 
         // when
-        boolean result = settings.containsAllSettings(SettingsFieldRetriever.getAllPropertyFields());
+        boolean result = SettingsMigrationService.containsAllSettings(
+            configuration, SettingsFieldRetriever.getAllPropertyFields());
 
         // then
         if (!result) {
-            FileConfiguration configuration =
-                (FileConfiguration) ReflectionTestUtils.getFieldValue(NewSetting.class, settings, "configuration");
-
             Set<String> knownProperties = getAllKnownPropertyPaths();
             List<String> missingProperties = new ArrayList<>();
             for (String path : knownProperties) {

src/test/java/fr/xephi/authme/settings/NewSettingIntegrationTest.java

@@ -2,10 +2,10 @@ package fr.xephi.authme.settings;
 
 import com.google.common.collect.ImmutableMap;
 import fr.xephi.authme.ReflectionTestUtils;
-import fr.xephi.authme.settings.NewSetting;
 import fr.xephi.authme.settings.domain.Property;
 import fr.xephi.authme.settings.properties.TestConfiguration;
 import fr.xephi.authme.settings.propertymap.PropertyMap;
+import fr.xephi.authme.util.WrapperMock;
 import org.bukkit.configuration.file.YamlConfiguration;
 import org.junit.BeforeClass;
 import org.junit.Test;
@@ -35,6 +35,7 @@ public class NewSettingIntegrationTest {
 
     @BeforeClass
     public static void generatePropertyMap() {
+        WrapperMock.createInstance();
         propertyMap = new PropertyMap();
         for (Field field : TestConfiguration.class.getDeclaredFields()) {
             Object fieldValue = ReflectionTestUtils.getFieldValue(TestConfiguration.class, null, field.getName());

src/test/java/fr/xephi/authme/settings/NewSettingTest.java

@@ -1,6 +1,5 @@
 package fr.xephi.authme.settings;
 
-import fr.xephi.authme.settings.NewSetting;
 import fr.xephi.authme.settings.domain.Property;
 import fr.xephi.authme.settings.properties.TestConfiguration;
 import org.bukkit.configuration.file.YamlConfiguration;