fix TempbanManager injecting

This commit is contained in:
Gnat008 2016-06-12 15:17:37 -04:00
parent 69100daba5
commit 67c72dc46d
2 changed files with 20 additions and 6 deletions

View File

@ -34,8 +34,10 @@ public class TempbanManager implements SettingsDependent {
private int length; private int length;
@Inject @Inject
TempbanManager(NewSetting settings) { TempbanManager(BukkitService bukkitService, Messages messages, NewSetting settings) {
playerCounts = new ConcurrentHashMap<>(); this.playerCounts = new ConcurrentHashMap<>();
this.bukkitService = bukkitService;
this.messages = messages;
loadSettings(settings); loadSettings(settings);
} }

View File

@ -1,9 +1,14 @@
package fr.xephi.authme.cache; package fr.xephi.authme.cache;
import fr.xephi.authme.ReflectionTestUtils; import fr.xephi.authme.ReflectionTestUtils;
import fr.xephi.authme.output.Messages;
import fr.xephi.authme.settings.NewSetting; import fr.xephi.authme.settings.NewSetting;
import fr.xephi.authme.settings.properties.SecuritySettings; import fr.xephi.authme.settings.properties.SecuritySettings;
import fr.xephi.authme.util.BukkitService;
import org.junit.Test; import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.runners.MockitoJUnitRunner;
import java.util.Map; import java.util.Map;
@ -15,13 +20,20 @@ import static org.mockito.Mockito.mock;
/** /**
* Test for {@link TempbanManager}. * Test for {@link TempbanManager}.
*/ */
@RunWith(MockitoJUnitRunner.class)
public class TempbanManagerTest { public class TempbanManagerTest {
@Mock
BukkitService bukkitService;
@Mock
Messages messages;
@Test @Test
public void shouldAddCounts() { public void shouldAddCounts() {
// given // given
NewSetting settings = mockSettings(3, 60); NewSetting settings = mockSettings(3, 60);
TempbanManager manager = new TempbanManager(settings); TempbanManager manager = new TempbanManager(bukkitService, messages, settings);
String player = "Tester"; String player = "Tester";
// when // when
@ -41,7 +53,7 @@ public class TempbanManagerTest {
// given // given
String player = "plaYah"; String player = "plaYah";
NewSetting settings = mockSettings(3, 60); NewSetting settings = mockSettings(3, 60);
TempbanManager manager = new TempbanManager(settings); TempbanManager manager = new TempbanManager(bukkitService, messages, settings);
// when // when
manager.increaseCount(player); manager.increaseCount(player);
@ -66,7 +78,7 @@ public class TempbanManagerTest {
String player = "playah"; String player = "playah";
NewSetting settings = mockSettings(1, 5); NewSetting settings = mockSettings(1, 5);
given(settings.getProperty(SecuritySettings.TEMPBAN_ON_MAX_LOGINS)).willReturn(false); given(settings.getProperty(SecuritySettings.TEMPBAN_ON_MAX_LOGINS)).willReturn(false);
TempbanManager manager = new TempbanManager(settings); TempbanManager manager = new TempbanManager(bukkitService, messages, settings);
// when // when
manager.increaseCount(player); manager.increaseCount(player);
@ -81,7 +93,7 @@ public class TempbanManagerTest {
// given // given
String player = "playah"; String player = "playah";
NewSetting settings = mockSettings(1, 5); NewSetting settings = mockSettings(1, 5);
TempbanManager manager = new TempbanManager(settings); TempbanManager manager = new TempbanManager(bukkitService, messages, settings);
given(settings.getProperty(SecuritySettings.TEMPBAN_ON_MAX_LOGINS)).willReturn(false); given(settings.getProperty(SecuritySettings.TEMPBAN_ON_MAX_LOGINS)).willReturn(false);
// when // when