#765 Replace Utils usages with TeleportService + misc householding

- Remove some legacy settings
- Move Utils "addNormal" method to AuthGroupHandler

(Reapplied changes from orphaned fe29089)

src/main/java/fr/xephi/authme/process/logout/AsynchronousLogout.java

@@ -52,6 +52,7 @@ public class AsynchronousLogout implements AsynchronousProcess {
 
         limboCache.updateLimboPlayer(player);
         playerCache.removePlayer(name);
+        // TODO LJ: No more teleport here?
         database.setUnlogged(name);
         syncProcessManager.processSyncPlayerLogout(player);
     }

src/main/java/fr/xephi/authme/process/quit/AsynchronousQuit.java

@@ -12,6 +12,7 @@ import fr.xephi.authme.process.SyncProcessManager;
 import fr.xephi.authme.settings.SpawnLoader;
 import fr.xephi.authme.settings.properties.PluginSettings;
 import fr.xephi.authme.settings.properties.RestrictionSettings;
+import fr.xephi.authme.util.BukkitService;
 import fr.xephi.authme.util.Utils;
 import org.bukkit.Location;
 import org.bukkit.entity.Player;
@@ -44,6 +45,9 @@ public class AsynchronousQuit implements AsynchronousProcess {
     @Inject
     private SpawnLoader spawnLoader;
 
+    @Inject
+    private BukkitService bukkitService;
+
     AsynchronousQuit() {
     }
 
@@ -76,7 +80,7 @@ public class AsynchronousQuit implements AsynchronousProcess {
         playerCache.removePlayer(name);
 
         if (plugin.isEnabled() && service.getProperty(PluginSettings.SESSIONS_ENABLED)) {
-            BukkitTask task = plugin.getServer().getScheduler().runTaskLaterAsynchronously(plugin, new Runnable() {
+            BukkitTask task = bukkitService.runTaskLaterAsynchronously(new Runnable() {
 
                 @Override
                 public void run() {

src/main/java/fr/xephi/authme/process/quit/ProcessSyncronousPlayerQuit.java

@@ -3,6 +3,7 @@ package fr.xephi.authme.process.quit;
 import fr.xephi.authme.cache.backup.JsonCache;
 import fr.xephi.authme.cache.limbo.LimboCache;
 import fr.xephi.authme.cache.limbo.LimboPlayer;
+import fr.xephi.authme.permission.AuthGroupHandler;
 import fr.xephi.authme.process.ProcessService;
 import fr.xephi.authme.process.SynchronousProcess;
 import fr.xephi.authme.settings.properties.RestrictionSettings;
@@ -24,6 +25,9 @@ public class ProcessSyncronousPlayerQuit implements SynchronousProcess {
     @Inject
     private LimboCache limboCache;
 
+    @Inject
+    private AuthGroupHandler authGroupHandler;
+
     public void processSyncQuit(Player player) {
         LimboPlayer limbo = limboCache.getLimboPlayer(player.getName().toLowerCase());
         if (limbo != null) { // it mean player is not authenticated
@@ -33,7 +37,7 @@ public class ProcessSyncronousPlayerQuit implements SynchronousProcess {
             } else {
                 // Restore data if its about to delete LimboPlayer
                 if (!StringUtils.isEmpty(limbo.getGroup())) {
-                    Utils.addNormal(player, limbo.getGroup());
+                    authGroupHandler.addNormal(player, limbo.getGroup());
                 }
                 player.setOp(limbo.isOperator());
                 player.setAllowFlight(limbo.isCanFly());

src/main/java/fr/xephi/authme/process/register/ProcessSyncPasswordRegister.java

@@ -80,7 +80,8 @@ public class ProcessSyncPasswordRegister implements SynchronousProcess {
      */
     private void requestLogin(Player player) {
         final String name = player.getName().toLowerCase();
-        Utils.teleportToSpawn(player);
+        // TODO #765: Check if teleportation is needed here, and how
+        // Utils.teleportToSpawn(player);
 
         limboCache.updateLimboPlayer(player);
         limboPlayerTaskManager.registerTimeoutTask(player);
@@ -95,7 +96,8 @@ public class ProcessSyncPasswordRegister implements SynchronousProcess {
         final String name = player.getName().toLowerCase();
         LimboPlayer limbo = limboCache.getLimboPlayer(name);
         if (limbo != null) {
-            Utils.teleportToSpawn(player);
+            // TODO #765: Check if teleportation is needed here, and how
+            // Utils.teleportToSpawn(player);
 
             if (service.getProperty(PROTECT_INVENTORY_BEFORE_LOGIN)) {
                 RestoreInventoryEvent event = new RestoreInventoryEvent(player);

src/main/java/fr/xephi/authme/process/unregister/AsynchronousUnregister.java

@@ -14,7 +14,7 @@ import fr.xephi.authme.settings.Settings;
 import fr.xephi.authme.settings.properties.RegistrationSettings;
 import fr.xephi.authme.settings.properties.RestrictionSettings;
 import fr.xephi.authme.task.LimboPlayerTaskManager;
-import fr.xephi.authme.util.Utils;
+import fr.xephi.authme.util.TeleportationService;
 import org.bukkit.entity.Player;
 import org.bukkit.potion.PotionEffect;
 import org.bukkit.potion.PotionEffectType;
@@ -43,6 +43,9 @@ public class AsynchronousUnregister implements AsynchronousProcess {
     @Inject
     private LimboPlayerTaskManager limboPlayerTaskManager;
 
+    @Inject
+    private TeleportationService teleportationService;
+
     AsynchronousUnregister() { }
 
 
@@ -56,7 +59,7 @@ public class AsynchronousUnregister implements AsynchronousProcess {
             }
 
             if (service.getProperty(RegistrationSettings.FORCE)) {
-                Utils.teleportToSpawn(player);
+                teleportationService.teleportOnJoin(player);
                 player.saveData();
                 playerCache.removePlayer(player.getName().toLowerCase());
                 if (!Settings.getRegisteredGroup.isEmpty()) {