diff --git a/.travis.yml b/.travis.yml
index 1645036e..3eab0c37 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,7 +1,7 @@
sudo: false
language: java
-jdk: oraclejdk7
+jdk: oraclejdk8
cache:
directories:
diff --git a/circle.yml b/circle.yml
index dea5e80c..80201e5e 100644
--- a/circle.yml
+++ b/circle.yml
@@ -1,6 +1,6 @@
machine:
java:
- version: oraclejdk7
+ version: oraclejdk8
general:
artifacts:
- "target/AuthMe-*.jar"
diff --git a/pom.xml b/pom.xml
index f913596b..39bb5567 100644
--- a/pom.xml
+++ b/pom.xml
@@ -48,7 +48,9 @@
+
UTF-8
+ UTF-8
AuthMe
@@ -57,9 +59,6 @@
Xephi, sgdc3, DNx5, timvisee, games647, ljacqu
Unknown
-
- 1.7
-
1.9-pre1-SNAPSHOT
@@ -147,14 +146,28 @@
-
+
org.apache.maven.plugins
maven-compiler-plugin
3.5.1
- 1.7
- ${javaVersion}
+ 1.8
+ 1.8
+
+ 1.7
+ 1.7
+
+
+
+
+ org.apache.maven.plugins
+ maven-surefire-plugin
+ 2.19.1
+
+ 3
+ true
+ -client -Xmx512M -Dfile.encoding=UTF-8 ${argLine}
@@ -717,7 +730,7 @@
net.minelink
CombatTagPlus
- 1.2.1-SNAPSHOT
+ 1.2.2-SNAPSHOT
provided
diff --git a/src/main/java/fr/xephi/authme/output/MessageKey.java b/src/main/java/fr/xephi/authme/output/MessageKey.java
index 45cdc0be..0c96b666 100644
--- a/src/main/java/fr/xephi/authme/output/MessageKey.java
+++ b/src/main/java/fr/xephi/authme/output/MessageKey.java
@@ -41,7 +41,7 @@ public enum MessageKey {
REGISTER_EMAIL_MESSAGE("reg_email_msg"),
- MAX_REGISTER_EXCEEDED("max_reg"),
+ MAX_REGISTER_EXCEEDED("max_reg", "%acc_nb"),
USAGE_REGISTER("usage_reg"),
diff --git a/src/main/java/fr/xephi/authme/process/login/ProcessSyncPlayerLogin.java b/src/main/java/fr/xephi/authme/process/login/ProcessSyncPlayerLogin.java
index 0c120b52..78995cb1 100644
--- a/src/main/java/fr/xephi/authme/process/login/ProcessSyncPlayerLogin.java
+++ b/src/main/java/fr/xephi/authme/process/login/ProcessSyncPlayerLogin.java
@@ -38,7 +38,6 @@ public class ProcessSyncPlayerLogin implements Runnable {
private final String name;
private final PlayerAuth auth;
private final AuthMe plugin;
- private final DataSource database;
private final PluginManager pm;
private final JsonCache playerCache;
private final NewSetting settings;
@@ -54,7 +53,6 @@ public class ProcessSyncPlayerLogin implements Runnable {
public ProcessSyncPlayerLogin(Player player, AuthMe plugin,
DataSource database, NewSetting settings) {
this.plugin = plugin;
- this.database = database;
this.pm = plugin.getServer().getPluginManager();
this.player = player;
this.name = player.getName().toLowerCase();
diff --git a/src/main/java/fr/xephi/authme/process/register/AsyncRegister.java b/src/main/java/fr/xephi/authme/process/register/AsyncRegister.java
index e17c511d..97344ba0 100644
--- a/src/main/java/fr/xephi/authme/process/register/AsyncRegister.java
+++ b/src/main/java/fr/xephi/authme/process/register/AsyncRegister.java
@@ -1,5 +1,8 @@
package fr.xephi.authme.process.register;
+import org.bukkit.Bukkit;
+import org.bukkit.entity.Player;
+
import fr.xephi.authme.AuthMe;
import fr.xephi.authme.cache.auth.PlayerAuth;
import fr.xephi.authme.cache.auth.PlayerCache;
@@ -13,8 +16,6 @@ import fr.xephi.authme.security.crypts.TwoFactor;
import fr.xephi.authme.settings.NewSetting;
import fr.xephi.authme.settings.Settings;
import fr.xephi.authme.util.StringUtils;
-import org.bukkit.Bukkit;
-import org.bukkit.entity.Player;
/**
*/
@@ -71,6 +72,7 @@ public class AsyncRegister {
}
//check this in both possiblities so don't use 'else if'
+ Integer size = 0;
if (database.isAuthAvailable(name)) {
m.send(player, MessageKey.NAME_ALREADY_REGISTERED);
return false;
@@ -78,8 +80,8 @@ public class AsyncRegister {
&& !plugin.getPermissionsManager().hasPermission(player, PlayerStatePermission.ALLOW_MULTIPLE_ACCOUNTS)
&& !ip.equalsIgnoreCase("127.0.0.1")
&& !ip.equalsIgnoreCase("localhost")
- && database.getAllAuthsByIp(ip).size() >= Settings.getmaxRegPerIp) {
- m.send(player, MessageKey.MAX_REGISTER_EXCEEDED);
+ && (size = database.getAllAuthsByIp(ip).size()) >= Settings.getmaxRegPerIp) {
+ m.send(player, MessageKey.MAX_REGISTER_EXCEEDED, size.toString());
return false;
}
return true;
@@ -96,10 +98,11 @@ public class AsyncRegister {
}
private void emailRegister() {
+ Integer size = 0;
if (Settings.getmaxRegPerEmail > 0
&& !plugin.getPermissionsManager().hasPermission(player, PlayerStatePermission.ALLOW_MULTIPLE_ACCOUNTS)
- && database.countAuthsByEmail(email) >= Settings.getmaxRegPerEmail) {
- m.send(player, MessageKey.MAX_REGISTER_EXCEEDED);
+ && (size = database.countAuthsByEmail(email)) >= Settings.getmaxRegPerEmail) {
+ m.send(player, MessageKey.MAX_REGISTER_EXCEEDED, size.toString());
return;
}
final HashedPassword hashedPassword = plugin.getPasswordSecurity().computeHash(password, name);
diff --git a/src/main/java/fr/xephi/authme/util/Profiler.java b/src/main/java/fr/xephi/authme/util/Profiler.java
index 0784aa65..73bdf5e4 100644
--- a/src/main/java/fr/xephi/authme/util/Profiler.java
+++ b/src/main/java/fr/xephi/authme/util/Profiler.java
@@ -2,15 +2,13 @@ package fr.xephi.authme.util;
import java.text.DecimalFormat;
-/**
- */
-@SuppressWarnings("UnusedDeclaration")
public class Profiler {
/**
* Defines the past time in milliseconds.
*/
private long time = 0;
+
/**
* Defines the time in milliseconds the profiler last started at.
*/
diff --git a/src/main/resources/messages/messages_en.yml b/src/main/resources/messages/messages_en.yml
index 1b1ae61e..4e155bcf 100644
--- a/src/main/resources/messages/messages_en.yml
+++ b/src/main/resources/messages/messages_en.yml
@@ -12,7 +12,7 @@ login: '&2Successful login!'
vb_nonActiv: '&cYour account isn''t activated yet, please check your emails!'
user_regged: '&cYou already have registered this username!'
usage_reg: '&cUsage: /register '
-max_reg: '&cYou have exceeded the maximum number of registrations for your connection!'
+max_reg: '&cYou have exceeded the maximum number of registrations (%acc_nb) for your connection!'
no_perm: '&4You don''t have the permission to perform this action!'
error: '&4An unexpected error occurred, please contact an administrator!'
login_msg: '&cPlease, login with the command "/login "'
diff --git a/src/test/java/fr/xephi/authme/datasource/AbstractResourceClosingTest.java b/src/test/java/fr/xephi/authme/datasource/AbstractResourceClosingTest.java
index 5b215a90..f5ba58e8 100644
--- a/src/test/java/fr/xephi/authme/datasource/AbstractResourceClosingTest.java
+++ b/src/test/java/fr/xephi/authme/datasource/AbstractResourceClosingTest.java
@@ -167,7 +167,9 @@ public abstract class AbstractResourceClosingTest {
* Verify that all AutoCloseables that have been created during the method execution have been closed.
*/
private void verifyHaveMocksBeenClosed() {
- System.out.println("Found " + closeables.size() + " resources");
+ if (closeables.isEmpty()) {
+ System.out.println("Note: detected no AutoCloseables for method '" + method.getName() + "'");
+ }
try {
for (AutoCloseable autoCloseable : closeables) {
verify(autoCloseable).close();