Revise converter architecture + add integration test for CrazyLogin converter

src/test/java/fr/xephi/authme/converter/CrazyLoginConverterTest.java

@@ -0,0 +1,95 @@
+package fr.xephi.authme.converter;
+
+import fr.xephi.authme.TestHelper;
+import fr.xephi.authme.cache.auth.PlayerAuth;
+import fr.xephi.authme.datasource.DataSource;
+import fr.xephi.authme.settings.NewSetting;
+import fr.xephi.authme.settings.properties.ConverterSettings;
+import org.bukkit.command.CommandSender;
+import org.junit.Before;
+import org.junit.BeforeClass;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.mockito.ArgumentCaptor;
+import org.mockito.Mock;
+import org.mockito.runners.MockitoJUnitRunner;
+
+import java.io.File;
+import java.util.List;
+
+import static fr.xephi.authme.AuthMeMatchers.equalToHash;
+import static org.hamcrest.Matchers.containsString;
+import static org.hamcrest.Matchers.equalTo;
+import static org.junit.Assert.assertThat;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.Matchers.argThat;
+import static org.mockito.Mockito.mock;
+import static org.mockito.Mockito.times;
+import static org.mockito.Mockito.verify;
+import static org.mockito.Mockito.verifyZeroInteractions;
+
+/**
+ * Test for {@link CrazyLoginConverter}.
+ */
+@RunWith(MockitoJUnitRunner.class)
+public class CrazyLoginConverterTest {
+
+    private CrazyLoginConverter crazyLoginConverter;
+
+    @Mock
+    private DataSource dataSource;
+
+    @Mock
+    private NewSetting settings;
+
+    private File dataFolder = TestHelper.getJarFile("/converter/");
+
+    @BeforeClass
+    public static void initializeLogger() {
+        TestHelper.setupLogger();
+    }
+
+    @Before
+    public void instantiateConverter() {
+        crazyLoginConverter = new CrazyLoginConverter(dataFolder, dataSource, settings);
+    }
+
+    @Test
+    public void shouldImportUsers() {
+        // given
+        given(settings.getProperty(ConverterSettings.CRAZYLOGIN_FILE_NAME)).willReturn("crazylogin.db");
+        CommandSender sender = mock(CommandSender.class);
+
+        // when
+        crazyLoginConverter.execute(sender);
+
+        // then
+        ArgumentCaptor<PlayerAuth> authCaptor = ArgumentCaptor.forClass(PlayerAuth.class);
+        verify(dataSource, times(2)).saveAuth(authCaptor.capture());
+        List<PlayerAuth> savedAuths = authCaptor.getAllValues();
+        assertNameAndRealName(savedAuths.get(0), "qotato", "qotaTo");
+        assertThat(savedAuths.get(0).getPassword(), equalToHash("8267663ab198a96437b9f455429a2c1b6c943111613c217bf2703c14d08a309d34e510ddb5549507b1500759dbcf9d4a99bc765ff37b32bd31adbb1e92e74ac5"));
+        assertNameAndRealName(savedAuths.get(1), "bobby", "Bobby");
+        assertThat(savedAuths.get(1).getPassword(), equalToHash("ad50dbc841e6321210530801f5219a5ffb4c7c41f11878d465374a4b8db2965c50f69b6098918a58e4adea312e3633c7724b15e24a217009e6fa2b3c299d55f2"));
+    }
+
+    @Test
+    public void shouldStopForNonExistentFile() {
+        // given
+        given(settings.getProperty(ConverterSettings.CRAZYLOGIN_FILE_NAME)).willReturn("invalid-file");
+        CommandSender sender = mock(CommandSender.class);
+
+        // when
+        crazyLoginConverter.execute(sender);
+
+        // then
+        verifyZeroInteractions(dataSource);
+        verify(sender).sendMessage(argThat(containsString("file not found")));
+    }
+
+    private static void assertNameAndRealName(PlayerAuth auth, String name, String realName) {
+        assertThat(auth.getNickname(), equalTo(name));
+        assertThat(auth.getRealName(), equalTo(realName));
+    }
+
+}

src/test/java/fr/xephi/authme/converter/ForceFlatToSqliteTest.java

@@ -54,7 +54,7 @@ public class ForceFlatToSqliteTest {
         ForceFlatToSqlite converter = new ForceFlatToSqlite(flatFile, dataSource);
 
         // when
-        converter.run();
+        converter.execute(null);
 
         // then
         ArgumentCaptor<PlayerAuth> authCaptor = ArgumentCaptor.forClass(PlayerAuth.class);

src/test/resources/converter/crazylogin.db

@@ -0,0 +1,3 @@
+name|password|ips|lastAction|loginFails|passwordExpired
+qotaTo|8267663ab198a96437b9f455429a2c1b6c943111613c217bf2703c14d08a309d34e510ddb5549507b1500759dbcf9d4a99bc765ff37b32bd31adbb1e92e74ac5|127.0.0.1|2016-05-27 21:45:57|0|false
+Bobby|ad50dbc841e6321210530801f5219a5ffb4c7c41f11878d465374a4b8db2965c50f69b6098918a58e4adea312e3633c7724b15e24a217009e6fa2b3c299d55f2|127.0.0.1|2016-05-27 21:45:40|0|false