#347 Test that all read properties exist as Property field

- Create consistency test to verify that all properties in config.yml are defined as a Property field in a SettingsClass implementation (currently fails)
- Add some missing properties
- Minor: convert tabs to spaces

src/test/java/fr/xephi/authme/settings/custom/ConfigFileConsistencyTest.java

@@ -1,14 +1,24 @@
 package fr.xephi.authme.settings.custom;
 
+import fr.xephi.authme.settings.domain.Property;
+import fr.xephi.authme.settings.propertymap.PropertyMap;
+import fr.xephi.authme.util.StringUtils;
+import org.bukkit.configuration.MemorySection;
+import org.bukkit.configuration.file.YamlConfiguration;
 import org.junit.Test;
 
 import java.io.File;
 import java.io.IOException;
 import java.net.URL;
+import java.util.ArrayList;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
 
 import static org.hamcrest.Matchers.equalTo;
 import static org.junit.Assert.assertThat;
-import static org.junit.Assume.assumeThat;
+import static org.junit.Assert.fail;
 
 /**
  * Test for {@link NewSetting} and the project's config.yml,
@@ -16,14 +26,15 @@ import static org.junit.Assume.assumeThat;
  */
 public class ConfigFileConsistencyTest {
 
+    /** The file name of the project's sample config file. */
+    private static final String CONFIG_FILE = "/config.yml";
+
     @Test
     public void shouldHaveAllConfigs() throws IOException {
-        URL url = this.getClass().getResource("/config.yml");
-        File configFile = new File(url.getFile());
-
         // given
-        assumeThat(configFile.exists(), equalTo(true));
-        NewSetting settings = new NewSetting(configFile);
+        URL url = this.getClass().getResource(CONFIG_FILE);
+        File configFile = new File(url.getFile());
+        NewSetting settings = new NewSetting(YamlConfiguration.loadConfiguration(configFile), new File("bogus"), null);
 
         // when
         boolean result = settings.containsAllSettings(SettingsFieldRetriever.getAllPropertyFields());
@@ -32,4 +43,38 @@ public class ConfigFileConsistencyTest {
         assertThat(result, equalTo(true));
     }
 
+    @Test
+    public void shouldNotHaveUnknownConfigs() {
+        // given
+        URL url = this.getClass().getResource(CONFIG_FILE);
+        File configFile = new File(url.getFile());
+        YamlConfiguration configuration = YamlConfiguration.loadConfiguration(configFile);
+        Map<String, Object> allReadProperties = configuration.getValues(true);
+        Set<String> knownKeys = getAllKnownPropertyPaths();
+
+        // when
+        List<String> unknownPaths = new ArrayList<>();
+        for (Map.Entry<String, Object> entry : allReadProperties.entrySet()) {
+            // The value being a MemorySection means it's a parent node
+            if (!(entry.getValue() instanceof MemorySection) && !knownKeys.contains(entry.getKey())) {
+                unknownPaths.add(entry.getKey());
+            }
+        }
+
+        // then
+        if (!unknownPaths.isEmpty()) {
+            fail("Found " + unknownPaths.size() + " unknown property paths in the project's config.yml: \n- "
+                + StringUtils.join("\n- ", unknownPaths));
+        }
+    }
+
+    private static Set<String> getAllKnownPropertyPaths() {
+        PropertyMap propertyMap = SettingsFieldRetriever.getAllPropertyFields();
+        Set<String> paths = new HashSet<>(propertyMap.size());
+        for (Property<?> property : propertyMap.keySet()) {
+            paths.add(property.getPath());
+        }
+        return paths;
+    }
+
 }

src/test/java/fr/xephi/authme/settings/custom/SettingsClassConsistencyTest.java

@@ -54,7 +54,7 @@ public class SettingsClassConsistencyTest {
             for (Field field : fields) {
                 if (Property.class.isAssignableFrom(field.getType())) {
                     String fieldName = "Field " + clazz.getSimpleName() + "#" + field.getName();
-                    assertThat(fieldName + "should be public, static, and final",
+                    assertThat(fieldName + " should be public, static, and final",
                         isValidConstantField(field), equalTo(true));
                 }
             }