Testing - check return value of Set#add instead of separately checking Set#contains

2016-07-03 11:47:37 +02:00
parent 2420a83ec3
commit 8f5817883e
6 changed files with 6 additions and 12 deletions
@@ -22,12 +22,11 @@ public class MessageKeyTest {
        // when / then
        for (MessageKey messageKey : messageKeys) {
            String key = messageKey.getKey();
-            if (keys.contains(key)) {
+            if (!keys.add(key)) {
                fail("Found key '" + messageKey.getKey() + "' twice!");
            } else if (StringUtils.isEmpty(key)) {
                fail("Key for message key '" + messageKey + "' is empty");
            }
-            keys.add(key);
        }
    }
 }