#727 Remove CommandService being passed as parameter to other methods

- No longer need to pass as param to other methods since CommandService is now an injected field
This commit is contained in:
ljacqu
2016-06-04 21:16:58 +02:00
parent 26ac466035
commit 91111ca476
3 changed files with 16 additions and 18 deletions
@@ -30,18 +30,18 @@ public class CaptchaCommand extends PlayerCommand {
} else if (!captchaManager.isCaptchaRequired(playerName)) {
commandService.send(player, MessageKey.USAGE_LOGIN);
} else {
checkCaptcha(player, arguments.get(0), commandService);
checkCaptcha(player, arguments.get(0));
}
}
private void checkCaptcha(Player player, String captchaCode, CommandService service) {
private void checkCaptcha(Player player, String captchaCode) {
final boolean isCorrectCode = captchaManager.checkCode(player.getName(), captchaCode);
if (isCorrectCode) {
service.send(player, MessageKey.CAPTCHA_SUCCESS);
service.send(player, MessageKey.LOGIN_MESSAGE);
commandService.send(player, MessageKey.CAPTCHA_SUCCESS);
commandService.send(player, MessageKey.LOGIN_MESSAGE);
} else {
String newCode = captchaManager.generateCode(player.getName());
service.send(player, MessageKey.CAPTCHA_WRONG_ERROR, newCode);
commandService.send(player, MessageKey.CAPTCHA_WRONG_ERROR, newCode);
}
}
}