#358 Remove old methods on PasswordSecurity, unify hash + salt

- For encryption methods with a separate salt, the hash is useless without the salt, so hash and salt should always be persisted and retrieved together

src/main/java/fr/xephi/authme/process/login/AsynchronousLogin.java

@@ -136,9 +136,9 @@ public class AsynchronousLogin {
         if (pAuth == null || needsCaptcha())
             return;
 
-        String hash = pAuth.getHash();
         String email = pAuth.getEmail();
-        boolean passwordVerified = forceLogin || plugin.getPasswordSecurity().comparePassword(password, hash, realName);
+        boolean passwordVerified = forceLogin || plugin.getPasswordSecurity()
+            .comparePassword(password, pAuth.getHash(), pAuth.getSalt(), realName);
 
         if (passwordVerified && player.isOnline()) {
             PlayerAuth auth = PlayerAuth.builder()
@@ -147,7 +147,7 @@ public class AsynchronousLogin {
                 .ip(getIP())
                 .lastLogin(new Date().getTime())
                 .email(email)
-                .hash(hash)
+                .hash(pAuth.getHash())
                 .salt(pAuth.getSalt())
                 .build();
             database.updateSession(auth);

src/main/java/fr/xephi/authme/process/unregister/AsynchronousUnregister.java

@@ -2,6 +2,7 @@ package fr.xephi.authme.process.unregister;
 
 import fr.xephi.authme.AuthMe;
 import fr.xephi.authme.ConsoleLogger;
+import fr.xephi.authme.cache.auth.PlayerAuth;
 import fr.xephi.authme.cache.auth.PlayerCache;
 import fr.xephi.authme.cache.backup.JsonCache;
 import fr.xephi.authme.cache.limbo.LimboCache;
@@ -52,7 +53,9 @@ public class AsynchronousUnregister {
     }
 
     public void process() {
-        if (force || plugin.getPasswordSecurity().comparePassword(password, PlayerCache.getInstance().getAuth(name).getHash(), player.getName())) {
+        PlayerAuth cachedAuth = PlayerCache.getInstance().getAuth(name);
+        if (force || plugin.getPasswordSecurity().comparePassword(
+            password, cachedAuth.getHash(), cachedAuth.getSalt(), player.getName())) {
             if (!plugin.getDataSource().removeAuth(name)) {
                 m.send(player, MessageKey.ERROR);
                 return;