Minor - fix some small todo's

src/main/java/fr/xephi/authme/data/limbo/persistence/DistributedFilesPersistenceHandler.java

@@ -41,10 +41,7 @@ class DistributedFilesPersistenceHandler implements LimboPersistenceHandler {
     @Inject
     DistributedFilesPersistenceHandler(@DataFolder File dataFolder, BukkitService bukkitService, Settings settings) {
         cacheFolder = new File(dataFolder, "playerdata");
-        if (!cacheFolder.exists()) {
-            // TODO ljacqu 20170313: Create FileUtils#mkdirs
-            cacheFolder.mkdirs();
-        }
+        FileUtils.createDirectory(cacheFolder);
 
         gson = new GsonBuilder()
             .registerTypeAdapter(LimboPlayer.class, new LimboPlayerSerializer())

src/main/java/fr/xephi/authme/datasource/converter/RakamakConverter.java

@@ -8,6 +8,7 @@ import fr.xephi.authme.security.PasswordSecurity;
 import fr.xephi.authme.security.crypts.HashedPassword;
 import fr.xephi.authme.settings.Settings;
 import fr.xephi.authme.settings.properties.ConverterSettings;
+import fr.xephi.authme.util.Utils;
 import org.bukkit.command.CommandSender;
 
 import javax.inject.Inject;
@@ -85,8 +86,7 @@ public class RakamakConverter implements Converter {
                     .build();
                 database.saveAuth(auth);
             }
-            ConsoleLogger.info("Rakamak database has been imported correctly");
-            sender.sendMessage("Rakamak database has been imported correctly");
+            Utils.logAndSendMessage(sender, "Rakamak database has been imported correctly");
         } catch (IOException ex) {
             ConsoleLogger.logException("Can't open the rakamak database file! Does it exist?", ex);
         }

src/main/java/fr/xephi/authme/security/HashUtils.java

@@ -85,12 +85,22 @@ public final class HashUtils {
      * @param algorithm The algorithm to hash the message with
      * @return The digest in its hexadecimal representation
      */
-    private static String hash(String message, MessageDigestAlgorithm algorithm) {
-        MessageDigest md = getDigest(algorithm);
-        md.reset();
-        md.update(message.getBytes());
-        byte[] digest = md.digest();
+    public static String hash(String message, MessageDigest algorithm) {
+        algorithm.reset();
+        algorithm.update(message.getBytes());
+        byte[] digest = algorithm.digest();
         return String.format("%0" + (digest.length << 1) + "x", new BigInteger(1, digest));
     }
 
+    /**
+     * Hash the message with the given algorithm and return the hash in its hexadecimal notation.
+     *
+     * @param message The message to hash
+     * @param algorithm The algorithm to hash the message with
+     * @return The digest in its hexadecimal representation
+     */
+    private static String hash(String message, MessageDigestAlgorithm algorithm) {
+        return hash(message, getDigest(algorithm));
+    }
+
 }

src/main/java/fr/xephi/authme/security/crypts/RoyalAuth.java

@@ -1,14 +1,17 @@
 package fr.xephi.authme.security.crypts;
 
 import fr.xephi.authme.security.HashUtils;
+import fr.xephi.authme.security.MessageDigestAlgorithm;
+
+import java.security.MessageDigest;
 
 public class RoyalAuth extends UnsaltedMethod {
 
     @Override
     public String computeHash(String password) {
-        for (int i = 0; i < 25; i++) {
-            // TODO ljacqu 20151228: HashUtils#sha512 gets a new message digest each time...
-            password = HashUtils.sha512(password);
+        MessageDigest algorithm = HashUtils.getDigest(MessageDigestAlgorithm.SHA512);
+        for (int i = 0; i < 25; ++i) {
+            password = HashUtils.hash(password, algorithm);
         }
         return password;
     }

src/main/java/fr/xephi/authme/settings/SpawnLoader.java

@@ -45,7 +45,6 @@ public class SpawnLoader implements Reloadable {
      */
     @Inject
     SpawnLoader(@DataFolder File pluginFolder, Settings settings, PluginHookService pluginHookService) {
-        // TODO ljacqu 20160312: Check if resource could be copied and handle the case if not
         File spawnFile = new File(pluginFolder, "spawn.yml");
         FileUtils.copyFileFromResource(spawnFile, "spawn.yml");
         this.authMeConfigurationFile = spawnFile;

src/main/java/fr/xephi/authme/task/purge/PurgeExecutor.java

@@ -194,7 +194,6 @@ class PurgeExecutor {
     }
 
     // TODO: What is this method for? Is it correct?
-    // TODO: Make it work with OfflinePlayers group data.
     synchronized void purgePermissions(Collection<OfflinePlayer> cleared) {
         if (!settings.getProperty(PurgeSettings.REMOVE_PERMISSIONS)) {
             return;

src/main/java/fr/xephi/authme/util/FileUtils.java

@@ -30,7 +30,7 @@ public final class FileUtils {
     public static boolean copyFileFromResource(File destinationFile, String resourcePath) {
         if (destinationFile.exists()) {
             return true;
-        } else if (!destinationFile.getParentFile().exists() && !destinationFile.getParentFile().mkdirs()) {
+        } else if (!createDirectory(destinationFile.getParentFile())) {
             ConsoleLogger.warning("Cannot create parent directories for '" + destinationFile + "'");
             return false;
         }
@@ -50,6 +50,20 @@ public final class FileUtils {
         return false;
     }
 
+    /**
+     * Creates the given directory.
+     *
+     * @param dir the directory to create
+     * @return true upon success, false otherwise
+     */
+    public static boolean createDirectory(File dir) {
+        if (!dir.exists() && !dir.mkdirs()) {
+            ConsoleLogger.warning("Could not create directory '" + dir + "'");
+            return false;
+        }
+        return true;
+    }
+
     /**
      * Returns a JAR file as stream. Returns null if it doesn't exist.
      *