Listener optimizations (#1884)

* Drop CraftBukkit support, listeners cleanup

* Codestyle

* Codestyle

* Remove useless player.saveData() calls

* Micro optimization on the join process

* Requested changes

* Fix unit test

* Test onPlayerHeldItem listener

* Requested changes

* Remove unused import

src/main/java/fr/xephi/authme/process/join/AsynchronousJoin.java

@@ -89,8 +89,9 @@ public class AsynchronousJoin implements AsynchronousProcess {
         }
 
         if (service.getProperty(RestrictionSettings.FORCE_SURVIVAL_MODE)
+            && player.getGameMode() != GameMode.SURVIVAL
             && !service.hasPermission(player, PlayerStatePermission.BYPASS_FORCE_SURVIVAL)) {
-            bukkitService.runTask(() -> player.setGameMode(GameMode.SURVIVAL));
+            bukkitService.scheduleSyncTaskFromOptionallyAsyncTask(() -> player.setGameMode(GameMode.SURVIVAL));
         }
 
         if (service.getProperty(HooksSettings.DISABLE_SOCIAL_SPY)) {

src/main/java/fr/xephi/authme/process/login/ProcessSyncPlayerLogin.java

@@ -100,7 +100,6 @@ public class ProcessSyncPlayerLogin implements SynchronousProcess {
 
         // The Login event now fires (as intended) after everything is processed
         bukkitService.callEvent(new LoginEvent(player));
-        player.saveData();
 
         // Login is done, display welcome message
         welcomeMessageConfiguration.sendWelcomeMessage(player);

src/main/java/fr/xephi/authme/process/register/ProcessSyncEmailRegister.java

@@ -41,7 +41,6 @@ public class ProcessSyncEmailRegister implements SynchronousProcess {
         service.send(player, MessageKey.ACCOUNT_NOT_ACTIVATED);
         limboService.replaceTasksAfterRegistration(player);
 
-        player.saveData();
         bukkitService.callEvent(new RegisterEvent(player));
         logger.fine(player.getName() + " registered " + PlayerUtils.getPlayerIp(player));
     }

src/main/java/fr/xephi/authme/process/register/ProcessSyncPasswordRegister.java

@@ -67,7 +67,6 @@ public class ProcessSyncPasswordRegister implements SynchronousProcess {
             service.send(player, MessageKey.ADD_EMAIL_MESSAGE);
         }
 
-        player.saveData();
         bukkitService.callEvent(new RegisterEvent(player));
         logger.fine(player.getName() + " registered " + PlayerUtils.getPlayerIp(player));
 

src/main/java/fr/xephi/authme/process/unregister/AsynchronousUnregister.java

@@ -128,7 +128,6 @@ public class AsynchronousUnregister implements AsynchronousProcess {
 
         if (service.getProperty(RegistrationSettings.FORCE)) {
             teleportationService.teleportOnJoin(player);
-            player.saveData();
 
             bukkitService.scheduleSyncTaskFromOptionallyAsyncTask(() -> {
                 limboService.createLimboPlayer(player, false);