#1016 Update hash algorithms list, add test that Deprecated annotation is in sync between enum and hash impl. class
This commit is contained in:
@@ -4,6 +4,8 @@ import ch.jalu.injector.Injector;
|
||||
import ch.jalu.injector.InjectorBuilder;
|
||||
import fr.xephi.authme.security.crypts.EncryptionMethod;
|
||||
import fr.xephi.authme.security.crypts.HashedPassword;
|
||||
import fr.xephi.authme.security.crypts.description.Recommendation;
|
||||
import fr.xephi.authme.security.crypts.description.Usage;
|
||||
import fr.xephi.authme.settings.Settings;
|
||||
import fr.xephi.authme.settings.properties.HooksSettings;
|
||||
import fr.xephi.authme.settings.properties.SecuritySettings;
|
||||
@@ -12,6 +14,8 @@ import org.junit.BeforeClass;
|
||||
import org.junit.Test;
|
||||
|
||||
import java.util.HashSet;
|
||||
import java.util.LinkedList;
|
||||
import java.util.List;
|
||||
import java.util.Set;
|
||||
|
||||
import static org.hamcrest.Matchers.equalTo;
|
||||
@@ -70,4 +74,29 @@ public class HashAlgorithmIntegrationTest {
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
public void shouldBeDeprecatedIfEncryptionClassIsDeprecated() throws NoSuchFieldException {
|
||||
// given
|
||||
List<String> failedEntries = new LinkedList<>();
|
||||
|
||||
// when
|
||||
for (HashAlgorithm hashAlgorithm : HashAlgorithm.values()) {
|
||||
if (hashAlgorithm != HashAlgorithm.CUSTOM) {
|
||||
boolean isEnumDeprecated = HashAlgorithm.class.getDeclaredField(hashAlgorithm.name())
|
||||
.isAnnotationPresent(Deprecated.class);
|
||||
boolean isDeprecatedClass = hashAlgorithm.getClazz().isAnnotationPresent(Deprecated.class);
|
||||
Recommendation recommendation = hashAlgorithm.getClazz().getAnnotation(Recommendation.class);
|
||||
boolean hasDeprecatedUsage = recommendation != null && recommendation.value() == Usage.DEPRECATED;
|
||||
if (isEnumDeprecated != isDeprecatedClass || isEnumDeprecated != hasDeprecatedUsage) {
|
||||
failedEntries.add(hashAlgorithm + ": enum @Deprecated = " + isEnumDeprecated
|
||||
+ ", @Deprecated class = " + isDeprecatedClass + ", usage Deprecated = " + hasDeprecatedUsage);
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// then
|
||||
if (!failedEntries.isEmpty()) {
|
||||
fail("Found inconsistencies:\n" + String.join("\n", failedEntries));
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user