Replace enum with map in converter command

src/test/java/fr/xephi/authme/command/executable/authme/ConverterCommandTest.java

@@ -3,25 +3,30 @@ package fr.xephi.authme.command.executable.authme;
 import ch.jalu.injector.Injector;
 import fr.xephi.authme.TestHelper;
 import fr.xephi.authme.command.CommandService;
+import fr.xephi.authme.converter.Converter;
 import fr.xephi.authme.converter.RakamakConverter;
+import fr.xephi.authme.converter.vAuthConverter;
 import fr.xephi.authme.output.MessageKey;
 import fr.xephi.authme.util.BukkitService;
+import fr.xephi.authme.util.StringUtils;
 import org.bukkit.command.CommandSender;
+import org.junit.BeforeClass;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.runners.MockitoJUnitRunner;
 
-import java.util.ArrayList;
 import java.util.Collections;
-import java.util.List;
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
 
-import static org.hamcrest.Matchers.hasItem;
-import static org.hamcrest.Matchers.not;
-import static org.hamcrest.Matchers.nullValue;
+import static org.hamcrest.Matchers.equalTo;
 import static org.junit.Assert.assertThat;
 import static org.mockito.BDDMockito.given;
+import static org.mockito.Matchers.any;
+import static org.mockito.Mockito.doThrow;
 import static org.mockito.Mockito.mock;
 import static org.mockito.Mockito.verify;
 import static org.mockito.Mockito.verifyNoMoreInteractions;
@@ -45,6 +50,11 @@ public class ConverterCommandTest {
     @Mock
     private Injector injector;
 
+    @BeforeClass
+    public static void initLogger() {
+        TestHelper.setupLogger();
+    }
+
     @Test
     public void shouldHandleUnknownConversionType() {
         // given
@@ -61,44 +71,61 @@ public class ConverterCommandTest {
     }
 
     @Test
-    public void shouldHaveUniqueNameAndClassForEachType() {
+    public void shouldHaveUniqueClassForEachConverter() {
         // given
-        ConverterCommand.ConvertType[] types = ConverterCommand.ConvertType.values();
-        List<String> names = new ArrayList<>(types.length);
-        List<Class<?>> classes = new ArrayList<>(types.length);
+        Set<Class<? extends Converter>> classes = new HashSet<>();
 
         // when / then
-        for (ConverterCommand.ConvertType type : types) {
-            assertThat("Name for '" + type + "' is not null",
-                type.getName(), not(nullValue()));
-            assertThat("Class for '" + type + "' is not null",
-                type.getConverterClass(), not(nullValue()));
-            assertThat("Name '" + type.getName() + "' is unique",
-                names, not(hasItem(type.getName())));
-            assertThat("Class '" + type.getConverterClass() + "' is unique",
-                classes, not(hasItem(type.getConverterClass())));
-            names.add(type.getName());
-            classes.add(type.getConverterClass());
+        for (Map.Entry<String, Class<? extends Converter>> entry : ConverterCommand.CONVERTERS.entrySet()) {
+            assertThat("Name is not null or empty",
+                StringUtils.isEmpty(entry.getKey()), equalTo(false));
+
+            assertThat("Converter class is unique for each entry",
+                classes.add(entry.getValue()), equalTo(true));
         }
     }
 
     @Test
     public void shouldLaunchConverterForAllTypes() {
         // given
-        ConverterCommand.ConvertType type = ConverterCommand.ConvertType.RAKAMAK;
-        RakamakConverter converter = mock(RakamakConverter.class);
-        given(injector.newInstance(RakamakConverter.class)).willReturn(converter);
+        String converterName = "rakamak";
+        Class<? extends Converter> converterClass = ConverterCommand.CONVERTERS.get(converterName);
+        // Keep concrete class reference in mock: if this class is ever removed, we need to use another converterName
+        Converter converter = mock(RakamakConverter.class);
+        given(injector.newInstance(converterClass)).willReturn(converter);
         CommandSender sender = mock(CommandSender.class);
 
         // when
-        command.executeCommand(sender, Collections.singletonList(type.getName()));
+        command.executeCommand(sender, Collections.singletonList(converterName));
         TestHelper.runInnerRunnable(bukkitService);
 
         // then
         verify(converter).execute(sender);
         verifyNoMoreInteractions(converter);
-        verify(injector).newInstance(type.getConverterClass());
+        verify(injector).newInstance(converterClass);
         verifyNoMoreInteractions(injector);
     }
 
+    @Test
+    public void shouldCatchExceptionInConverterAndInformSender() {
+        // given
+        String converterName = "vauth";
+        Class<? extends Converter> converterClass = ConverterCommand.CONVERTERS.get(converterName);
+        Converter converter = mock(vAuthConverter.class);
+        doThrow(IllegalStateException.class).when(converter).execute(any(CommandSender.class));
+        given(injector.newInstance(converterClass)).willReturn(converter);
+        CommandSender sender = mock(CommandSender.class);
+
+        // when
+        command.executeCommand(sender, Collections.singletonList(converterName.toUpperCase()));
+        TestHelper.runInnerRunnable(bukkitService);
+
+        // then
+        verify(converter).execute(sender);
+        verifyNoMoreInteractions(converter);
+        verify(injector).newInstance(converterClass);
+        verifyNoMoreInteractions(injector);
+        verify(commandService).send(sender, MessageKey.ERROR);
+    }
+
 }