Minor: change bukkit service to return a plain collection of Player

- List is read-only and can be easily "upcast" to Collection<Player>
- Remove awkward hack that was needed for mocking the method previously (issues with generics)

src/main/java/fr/xephi/authme/command/executable/authme/VersionCommand.java

@@ -23,7 +23,7 @@ public class VersionCommand implements ExecutableCommand {
         sender.sendMessage(ChatColor.GOLD + "Version: " + ChatColor.WHITE + AuthMe.getPluginName()
             + " v" + AuthMe.getPluginVersion() + ChatColor.GRAY + " (build: " + AuthMe.getPluginBuildNumber() + ")");
         sender.sendMessage(ChatColor.GOLD + "Developers:");
-        Collection<? extends Player> onlinePlayers = bukkitService.getOnlinePlayers();
+        Collection<Player> onlinePlayers = bukkitService.getOnlinePlayers();
         printDeveloper(sender, "Alexandre Vanhecke", "xephi59", "Original Author", onlinePlayers);
         printDeveloper(sender, "Lucas J.", "ljacqu", "Main Developer", onlinePlayers);
         printDeveloper(sender, "Gnat008", "gnat008", "Developer", onlinePlayers);
@@ -49,7 +49,7 @@ public class VersionCommand implements ExecutableCommand {
      * @param onlinePlayers The list of online players
      */
     private static void printDeveloper(CommandSender sender, String name, String minecraftName, String function,
-                                       Collection<? extends Player> onlinePlayers) {
+                                       Collection<Player> onlinePlayers) {
         // Print the name
         StringBuilder msg = new StringBuilder();
         msg.append(" ")
@@ -77,7 +77,7 @@ public class VersionCommand implements ExecutableCommand {
      *
      * @return True if the player is online, false otherwise
      */
-    private static boolean isPlayerOnline(String minecraftName, Collection<? extends Player> onlinePlayers) {
+    private static boolean isPlayerOnline(String minecraftName, Collection<Player> onlinePlayers) {
         for (Player player : onlinePlayers) {
             if (player.getName().equalsIgnoreCase(minecraftName)) {
                 return true;

src/main/java/fr/xephi/authme/listener/OnJoinVerifier.java

@@ -128,7 +128,7 @@ public class OnJoinVerifier implements Reloadable {
         }
 
         // Server is full and player is VIP; attempt to kick a non-VIP player to make room
-        Collection<? extends Player> onlinePlayers = bukkitService.getOnlinePlayers();
+        Collection<Player> onlinePlayers = bukkitService.getOnlinePlayers();
         if (onlinePlayers.size() < server.getMaxPlayers()) {
             event.allow();
             return false;
@@ -207,7 +207,7 @@ public class OnJoinVerifier implements Reloadable {
      *
      * @return the player to kick, or null if none applicable
      */
-    private Player generateKickPlayer(Collection<? extends Player> onlinePlayers) {
+    private Player generateKickPlayer(Collection<Player> onlinePlayers) {
         for (Player player : onlinePlayers) {
             if (!permissionsManager.hasPermission(player, PlayerStatePermission.IS_VIP)) {
                 return player;

src/main/java/fr/xephi/authme/service/BukkitService.java

@@ -233,8 +233,9 @@ public class BukkitService implements SettingsDependent {
      *
      * @return collection of online players
      */
-    public Collection<? extends Player> getOnlinePlayers() {
-        return Bukkit.getOnlinePlayers();
+    @SuppressWarnings("unchecked")
+    public Collection<Player> getOnlinePlayers() {
+        return (Collection<Player>) Bukkit.getOnlinePlayers();
     }
 
     /**