ljacqu
ca0cbe6caf
Code householding
...
- Move console initialization for tests into TestHelper
- Remove unused properties in legacy Settings
- Add issue number to TODO comments where applicable
2016-04-14 12:28:19 +02:00
ljacqu
e2b50b72a5
Get player via BukkitService; add unit tests for commands
2016-04-08 19:56:44 +02:00
Gabriele C
ee177e8a3a
Remove the IPManager
...
We don't need it anymore
2016-04-08 14:34:21 +02:00
ljacqu
9ea75c502c
#567 Move email validation logic to validation service
2016-04-03 20:44:13 +02:00
ljacqu
c079692f1d
Minor - code householding (tests)
...
- Remove redundant uses of WrapperMock
- Use assertThat() from JUnit, not hamcrest
- Use hamcrest Matchers everywhere (not BaseMatchers etc.)
- Favor Mockito's argThat() over using ArgumentCaptor (more succinct)
- Delete useless test classes
2016-04-03 07:38:13 +02:00
ljacqu
4f86604699
Check valid password via service
...
- Create validation service; fixes same code being duplicated in four places
- Goal is to remove Utils class, by moving methods to validation service or other services
- Remove unused properties in legacy settings
2016-04-02 22:44:20 +02:00
ljacqu
55c24b8e64
Test AntiBot + SwitchAntiBotCommand
2016-03-24 22:11:40 +01:00
ljacqu
351b24fd14
Change AntiBot from static to instance
...
- Convert static methods in AntiBot
- Create BukkitService for operations requiring calls to static methods on the Bukkit class
2016-03-24 20:58:51 +01:00
Gabriele C
19070c220b
Blame eclipse warnings
2016-03-17 21:16:13 +01:00
ljacqu
5d12ec8b56
Minor fixes + code householding
...
- Fix SpawnCommandTest testing FirstSpawnCommand
- Fix javadoc errors
- Map TODO's to issue numbers where applicable
- Fix trivial TODO's
2016-03-13 11:09:27 +01:00
ljacqu
00125487f1
Create tests for admin commands
2016-03-13 10:17:09 +01:00
ljacqu
8293766f98
#421 Create SpawnLoader
...
- Non-static service class which handles the spawnpoints used in AuthMe
2016-03-12 18:25:38 +01:00
ljacqu
8b27444a49
#421 Create PluginHooks
...
- PluginHooks manages third-party plugins and allows to perform actions and queries on them, instead of public fields on the AuthMe main class
2016-03-12 18:24:34 +01:00
ljacqu
654cebd5a7
Minor - rename LimboPlayer methods + code householding
...
- Rename *taskId methods to *task to reflect what they handle
- Remove usages of Wrapper where applicable
- Replace some uses of legacy Settings with NewSetting calls
2016-03-06 15:46:49 +01:00
ljacqu
987c3fdb17
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-remove-public-ip-map
2016-03-06 14:42:32 +01:00
ljacqu
98df21d75a
#575 Hotfix for reload support
...
- Create temporary method for reloading any stateful entities -> a lot of duplicated code, to be fixed soon within #432
- Remove unused methods
2016-03-05 22:30:35 +01:00
ljacqu
19adcdcceb
Move managers to the cache package
...
- Not entirely accurate name but not really worth to have a separate package for managers
2016-03-05 16:03:00 +01:00
ljacqu
aeb8307a46
#432 #547 Remove public IP cache map; make processes use ProcessService
...
- Create IP address manager for handling and caching IP addresses -> outside of the manager I do not want to care about caching details
- Make more processes use the ProcessService in favor of statically injected objects
2016-03-01 22:47:28 +01:00
ljacqu
86042070e9
#573 Remove exclusion for permission node check in test
2016-03-01 20:48:15 +01:00
ljacqu
90e0dc1875
Various code householding
...
- Remove unused API on DataSource
- Add some sensible javadoc to DataSource
- Minor code simplification
2016-02-19 23:19:38 +01:00
Gabriele C
4620ead311
Fix number of commands in test
2016-02-19 16:42:48 +01:00
Gabriele C
2f2af829b0
Fix event listener priorities
2016-02-07 15:35:02 +01:00
ljacqu
b4b679d3b9
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 437-add-email
...
Conflicts:
src/main/java/fr/xephi/authme/datasource/MySQL.java
src/main/java/fr/xephi/authme/datasource/SQLite.java
src/main/java/fr/xephi/authme/process/Management.java
src/main/java/fr/xephi/authme/process/email/AsyncChangeEmail.java
2016-02-06 18:01:23 +01:00
ljacqu
e747dfeb7f
#450 Make reload & messages functionality use NewSetting
...
- Change ReloadCommand to use the new setting functionality
- Check and construct the messages file in NewSetting
- Unrelated: change MessagesManager not to extend CustomConfiguration anymore
2016-01-31 09:55:02 +01:00
ljacqu
724296e02b
#449 Migrate some properties to new settings
...
- Use new settings class for retrieving help header & backup configs
- Delete migrated configs from old settings
2016-01-30 13:19:05 +01:00
ljacqu
d4e3e55e07
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 437-add-email
2016-01-19 17:16:05 +01:00
ljacqu
200af9c4c4
Move new configs outside of 'custom' package
...
- Create properties package for storing the config properties
- Move NewSetting class to main settings pkg
2016-01-19 09:20:55 +01:00
ljacqu
e18be3024a
#347 Use NewSetting properties for change password command
2016-01-17 12:33:29 +01:00
ljacqu
8ed8b32589
#437 Add email should not allow to change email
...
- Create separate test for adding email
- Check that no email is yet registered for add email
2016-01-13 22:08:40 +01:00
ljacqu
4d2f39f06e
#306 Add tests for CommandHandler and CommandMapper
2016-01-09 22:51:22 +01:00
ljacqu
fc0b7c46ac
#306 Add permission manager to command service
...
- Inject permission manager into command service explicitly via constructor
- Change command mapper to only care about generating FoundCommandResult objects, and command handler to worry about dealing with it later on
2016-01-09 21:57:20 +01:00
ljacqu
3845c1e0eb
#347 Add NewSetting to command service
...
- Adjust NewSetting constructor to match needs in AuthMe
- Add NewSetting to the command service
- See CaptchaCommand for a sample replacement from Settings to NewSetting
2016-01-09 12:45:58 +01:00
Gabriele C
300a621e1c
cleanup
2015-12-30 22:28:45 +01:00
ljacqu
b3b751920a
#358 Replace usage of static PasswordSecurity methods
...
- Replace static methods to instance methods
- Use PlayerAuth builder instead of constructor
2015-12-29 00:13:20 +01:00
ljacqu
47e97244a7
#306 Create tests for CommandService and PlayerCommand
2015-12-26 20:58:05 +01:00
ljacqu
27fee3ca64
#306 Create PlayerCommand abstract type
...
- Create PlayerCommand to handle player-only command checks centrally and consistently
- Adjust tests
2015-12-26 19:47:47 +01:00
ljacqu
9e8f51c616
#306 Fully test HelpProvider and CommandSyntaxHelper
2015-12-24 15:26:25 +01:00
ljacqu
050275a0a6
#306 Fully test AccountsCommand
2015-12-24 12:19:14 +01:00
ljacqu
cb2ffca6d3
#306 Change help provider to non-static / add calls to help functionality
2015-12-23 23:51:39 +01:00
ljacqu
be942c2b36
#306 Fix tests for command mapper and command handler
...
- Export initializing and retrieval of test commands to a separate class
2015-12-23 18:04:46 +01:00
ljacqu
14f6ecd716
#306 Adjust ExecutableCommand implementations to interface
2015-12-23 14:55:04 +01:00
ljacqu
8ef1b2ae3e
#306 Add command service and set up constructor dependency injection
...
(work in progress)
- Pass all dependencies via constructor
- Encapsulate command handling more (e.g. split CommandHandler with new CommandMapper)
- Add help command to all base commands at one central point
See AccountsCommand or HelpCommand for an example of the advantages - all necessary functions come from CommandService; objects aren't retrieved through a singleton getInstance() method anymore
2015-12-23 14:54:45 +01:00
ljacqu
a928a4092d
#305 Fix label handling, add extensive tests for command handler
2015-12-19 16:27:00 +01:00
ljacqu
01a294a334
#305 Adjust behavior of label handling; cleanup
...
- Fix bugs in behavior (wrong labels being shown for help)
- Change order of labels and arguments in FoundCommandResult constructors
- Move FoundResultStatus enum to its own class
- Create test class for HelpProvider
2015-12-18 22:19:26 +01:00
ljacqu
d871939793
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into commands-refactor
...
Conflicts:
src/main/java/fr/xephi/authme/command/CommandUtils.java
src/main/java/fr/xephi/authme/command/executable/captcha/CaptchaCommand.java
2015-12-17 22:32:26 +01:00
ljacqu
cbf0996197
Logic for FoundCommandResult.Status / Add tests for CommandHandler
...
- Fix other tests
- Add logic for smaller pending FIXME's
2015-12-17 22:23:43 +01:00
ljacqu
bfebf6dc44
Add tests for CommandUtils, move purgeDirectory to its only use
2015-12-14 21:37:20 +01:00
ljacqu
282f777311
#336 Create command list generator in tools
...
- Add new conditional template tags [...] blabla [/...]
- Create logic for generating a list of commands
2015-12-14 21:07:03 +01:00
ljacqu
0fdc8d2810
Fix #338 Create test to verify consistent argument count
2015-12-14 16:24:09 +01:00
ljacqu
c48c56f08c
Change to new HelpProvider, adjust classes to new methods
2015-12-13 10:12:54 +01:00