Meishin/LoginSystem
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,289 Commits 10 Branches 53 Tags
Commit Graph

117 Commits

Author SHA1 Message Date
ljacqu
55f7e8097a #743 Add proper error message for "invalid chars in password" 
- Change password validation to return a ValidationResult object for passing message arguments
- Remove wrapping methods in ProcessService and CommandService and use ValidationService directly
 2016-06-03 12:51:49 +02:00
Gabriele C
eafb3b6653 cleanup 2016-06-03 00:07:25 +02:00
ljacqu
6d2597a980 #739 Fix command unit tests; adjust default handling 
(cherry picked from commit 61c119b)
 2016-06-02 23:12:01 +02:00
Gnat008
73272b5931 Remove all but one hasPermission() method in the PermissionsManager 
#739 (cherry picked from commit 65f3347)
 2016-06-02 23:11:47 +02:00
ljacqu
9b5009eb8c #742 Create test that plugin.yml corresponds to command definitions 
- Create test
- Fix definitions to correspond
 2016-06-02 15:49:21 +02:00
ljacqu
30b72bec4c #604 Fix HelpProvider tests 2016-05-30 23:49:59 +02:00
EbonJaguar
3ad00a45f9 Move default permissions out of Commands and into PermissionNode - fixes #606 2016-05-30 16:47:48 -04:00
ljacqu
9b1ee86b2f Trivial code householding 
- Replace `if (!x) ... else ...` with `if(x) ... else ...`
- Avoid throwing RuntimeException; use children
 2016-05-30 12:18:55 +02:00
ljacqu
53043ddc0d Create tool task that checks Mock fields of test classes 2016-05-21 11:54:54 +02:00
ljacqu
14002ee75c #704 Reload settings of ConsoleLogger on /authme reload 2016-05-19 19:46:02 +02:00
ljacqu
e04f7dc711 #704 Implement reloading via injector 
- Create interfaces Reloadable and SettingsDependent to recognize reloadable classes
- Iterate through instances in injector to reload
 2016-05-12 19:51:10 +02:00
ljacqu
8e878d6a5a Remove BukkitService from CommandService, inject where needed instead 2016-05-08 13:50:20 +02:00
ljacqu
5e5836f167 #432 Injector improvements 
- Separate FieldInjection from default fallback for no-Inject public no-args constructor classes
- Make CommandInitializer a normal, instantiable service
- Add various injections instead of fetching through command service
 2016-05-08 11:15:56 +02:00
ljacqu
3fe2f0b6a8 Add missing test matcher 
- Mock verifications need matchers on all parameters, or on none. Test fails otherwise
 2016-05-04 18:40:06 +02:00
Gabriele C
7c52460c87 Merge branch 'pre-injector' 2016-05-04 18:03:33 +02:00
Gabriele C
1ea2f98727 Start working on #687 
Next step: Future return of the async registration
 2016-05-04 18:01:47 +02:00
Gabriele C
5ceabe2146 Cleanup 2016-05-04 17:26:58 +02:00
ljacqu
491dc06de4 Fix RegisterAdminCommand test verifying that online player is kicked 2016-05-02 19:57:54 +02:00
ljacqu
f76a68cb26 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-dependency-injection 
Conflicts:
	src/main/java/fr/xephi/authme/AuthMe.java
	src/main/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommand.java
	src/main/java/fr/xephi/authme/hooks/PluginHooks.java
	src/main/java/fr/xephi/authme/listener/AuthMePlayerListener.java
	src/main/java/fr/xephi/authme/listener/AuthMeServerListener.java
	src/test/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommandTest.java
 2016-05-02 19:48:12 +02:00
ljacqu
9af596327a #432 Inject in commands: DataSource / AntiBot / PasswordSecurity / PlayerCache 
- Inject the services instead of passing them through the command service
 2016-05-02 18:52:34 +02:00
Xephi59
20a237dbdf [DEV] This test would fail until player couldn't be returned as he was 
kicked
 2016-05-02 03:38:25 +02:00
ljacqu
5963628fa6 #432 Add field injection to AccountsCommand 2016-04-27 22:59:44 +02:00
ljacqu
02079f1f5c #432 Create custom dependency injector 2016-04-27 22:49:20 +02:00
ljacqu
71515f188a #551 Email registration should fail if no server email is configured 
- Stop registration and issue an error if the email address setting is empty for email registration
- Refactor register command into smaller portions
- Create tests
 2016-04-15 14:37:47 +02:00
ljacqu
ca0cbe6caf Code householding 
- Move console initialization for tests into TestHelper
- Remove unused properties in legacy Settings
- Add issue number to TODO comments where applicable
 2016-04-14 12:28:19 +02:00
ljacqu
e2b50b72a5 Get player via BukkitService; add unit tests for commands 2016-04-08 19:56:44 +02:00
Gabriele C
ee177e8a3a Remove the IPManager 
We don't need it anymore
 2016-04-08 14:34:21 +02:00
ljacqu
9ea75c502c #567 Move email validation logic to validation service 2016-04-03 20:44:13 +02:00
ljacqu
c079692f1d Minor - code householding (tests) 
- Remove redundant uses of WrapperMock
- Use assertThat() from JUnit, not hamcrest
- Use hamcrest Matchers everywhere (not BaseMatchers etc.)
- Favor Mockito's argThat() over using ArgumentCaptor (more succinct)
- Delete useless test classes
 2016-04-03 07:38:13 +02:00
ljacqu
4f86604699 Check valid password via service 
- Create validation service; fixes same code being duplicated in four places
   - Goal is to remove Utils class, by moving methods to validation service or other services
 - Remove unused properties in legacy settings
 2016-04-02 22:44:20 +02:00
ljacqu
55c24b8e64 Test AntiBot + SwitchAntiBotCommand 2016-03-24 22:11:40 +01:00
ljacqu
351b24fd14 Change AntiBot from static to instance 
- Convert static methods in AntiBot
- Create BukkitService for operations requiring calls to static methods on the Bukkit class
 2016-03-24 20:58:51 +01:00
Gabriele C
19070c220b Blame eclipse warnings 2016-03-17 21:16:13 +01:00
ljacqu
5d12ec8b56 Minor fixes + code householding 
- Fix SpawnCommandTest testing FirstSpawnCommand
- Fix javadoc errors
- Map TODO's to issue numbers where applicable
- Fix trivial TODO's
 2016-03-13 11:09:27 +01:00
ljacqu
00125487f1 Create tests for admin commands 2016-03-13 10:17:09 +01:00
ljacqu
8293766f98 #421 Create SpawnLoader 
- Non-static service class which handles the spawnpoints used in AuthMe
 2016-03-12 18:25:38 +01:00
ljacqu
8b27444a49 #421 Create PluginHooks 
- PluginHooks manages third-party plugins and allows to perform actions and queries on them, instead of public fields on the AuthMe main class
 2016-03-12 18:24:34 +01:00
ljacqu
654cebd5a7 Minor - rename LimboPlayer methods + code householding 
- Rename *taskId methods to *task to reflect what they handle
- Remove usages of Wrapper where applicable
- Replace some uses of legacy Settings with NewSetting calls
 2016-03-06 15:46:49 +01:00
ljacqu
987c3fdb17 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-remove-public-ip-map 2016-03-06 14:42:32 +01:00
ljacqu
98df21d75a #575 Hotfix for reload support 
- Create temporary method for reloading any stateful entities -> a lot of duplicated code, to be fixed soon within #432
- Remove unused methods
 2016-03-05 22:30:35 +01:00
ljacqu
19adcdcceb Move managers to the cache package 
- Not entirely accurate name but not really worth to have a separate package for managers
 2016-03-05 16:03:00 +01:00
ljacqu
aeb8307a46 #432 #547 Remove public IP cache map; make processes use ProcessService 
- Create IP address manager for handling and caching IP addresses -> outside of the manager I do not want to care about caching details
- Make more processes use the ProcessService in favor of statically injected objects
 2016-03-01 22:47:28 +01:00
ljacqu
86042070e9 #573 Remove exclusion for permission node check in test 2016-03-01 20:48:15 +01:00
ljacqu
90e0dc1875 Various code householding 
- Remove unused API on DataSource
- Add some sensible javadoc to DataSource
- Minor code simplification
 2016-02-19 23:19:38 +01:00
Gabriele C
4620ead311 Fix number of commands in test 2016-02-19 16:42:48 +01:00
Gabriele C
2f2af829b0 Fix event listener priorities 2016-02-07 15:35:02 +01:00
ljacqu
b4b679d3b9 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 437-add-email 
Conflicts:
	src/main/java/fr/xephi/authme/datasource/MySQL.java
	src/main/java/fr/xephi/authme/datasource/SQLite.java
	src/main/java/fr/xephi/authme/process/Management.java
	src/main/java/fr/xephi/authme/process/email/AsyncChangeEmail.java
 2016-02-06 18:01:23 +01:00
ljacqu
e747dfeb7f #450 Make reload & messages functionality use NewSetting 
- Change ReloadCommand to use the new setting functionality
- Check and construct the messages file in NewSetting
- Unrelated: change MessagesManager not to extend CustomConfiguration anymore
 2016-01-31 09:55:02 +01:00
ljacqu
724296e02b #449 Migrate some properties to new settings 
- Use new settings class for retrieving help header & backup configs
- Delete migrated configs from old settings
 2016-01-30 13:19:05 +01:00
ljacqu
d4e3e55e07 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 437-add-email 2016-01-19 17:16:05 +01:00