Gabriele C
52c0c7dd64
playerlistener cleanup
2016-05-29 16:34:03 +02:00
ljacqu
64aacb12db
Unit test verifications done on joining
...
- Write unit tests for checks done when a player joins
- Move join event handler methods back to PlayerListener; move join check logic to new separate class
2016-05-29 15:00:16 +02:00
ljacqu
39d8a88142
Structure checks done in PlayerJoinListener as individual methods
2016-05-29 11:45:12 +02:00
ljacqu
2c92a8b52f
Move logic for join events in its own listener
2016-05-28 22:32:45 +02:00
ljacqu
25f5fdb45c
Code householding (PlayerListener / Settings)
...
- Use field on PlayerListener for storing nickname pattern -> repeatedly parsing pattern is expensive
- Remove unused legacy setting fields
- ForceFlatToSqlite cannot be run from converter command -> remove Converter interface to create more natural method signatures
2016-05-28 22:04:55 +02:00
ljacqu
87331d116c
Revise converter architecture + add integration test for CrazyLogin converter
2016-05-27 23:00:44 +02:00
ljacqu
8de1897412
Minor - Use explicit dependencies in ProcessService
...
- Replace AuthMe in favor of PermissionsManager
- Create missing tests for ProcessService
2016-05-24 18:25:38 +02:00
Gabriele C
da6431b4fc
Suppress injection test warnings
2016-05-23 23:16:40 +02:00
ljacqu
30f62547d8
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 707-process-as-service
2016-05-23 21:41:41 +02:00
ljacqu
53043ddc0d
Create tool task that checks Mock fields of test classes
2016-05-21 11:54:54 +02:00
ljacqu
c1885a381b
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 707-process-as-service
...
Conflicts:
src/main/java/fr/xephi/authme/process/join/AsynchronousJoin.java
src/main/java/fr/xephi/authme/process/login/AsynchronousLogin.java
2016-05-20 19:48:41 +02:00
ljacqu
3f039d641a
#707 Convert sync processes into services
2016-05-20 19:42:30 +02:00
ljacqu
244e1a2b7d
Injector - don't use instantiation fallback if PostConstruct method is present
...
- Do not instantiate classes with instantiation fallback if they have a PostConstruct method - thanks @sgdc3 for the hint
- Change Injector test to check exception messages also
2016-05-20 17:57:14 +02:00
Gabriele C
6abad1970c
Revert "Cleanup"
...
This reverts commit 95b65ae20a855d8d89aa42432553fc6f051b5c46.
2016-05-20 14:58:41 +02:00
Gabriele C
95b65ae20a
Cleanup
2016-05-19 23:06:55 +02:00
ljacqu
9a72fe53b0
Minor - code householding
...
- Update inaccurate javadoc
- Remove unnecessary require call in PHP integration sample
2016-05-19 21:55:42 +02:00
ljacqu
f014485789
Service injector - implement stricter requirements for PostConstruct methods
...
- Implement similar restrictions as prescribed by the PostConstruct documentation:
- Class may have at most one method annotated with PostConstruct
- PostConstruct method must return void
- Javadoc: replace mentions of injector construction where any injection method was meant
2016-05-19 21:50:48 +02:00
ljacqu
14002ee75c
#704 Reload settings of ConsoleLogger on /authme reload
2016-05-19 19:46:02 +02:00
ljacqu
f5c89e897f
#707 Convert async processes as services
...
(work in progress - rough, untested changes)
2016-05-17 19:49:06 +02:00
Gabriele C
df2329fd9a
Fix conflict
2016-05-16 16:27:59 +02:00
Gabriele C
c748501345
Fix Multiverse dependency + fix invalid test in Eclipse
2016-05-14 00:01:26 +02:00
ljacqu
9f5b995217
Fix datasource resource closing tests ( #1 )
2016-05-12 20:15:44 +02:00
ljacqu
e04f7dc711
#704 Implement reloading via injector
...
- Create interfaces Reloadable and SettingsDependent to recognize reloadable classes
- Iterate through instances in injector to reload
2016-05-12 19:51:10 +02:00
games647
b1957c9812
Do not lookup twice for banned players
2016-05-09 21:51:21 +02:00
ljacqu
223f56425b
#699 Unit test that config.yml values correspond to property defaults
...
- Create unit test
- Correct offending values
2016-05-09 21:15:11 +02:00
ljacqu
8e878d6a5a
Remove BukkitService from CommandService, inject where needed instead
2016-05-08 13:50:20 +02:00
ljacqu
5e5836f167
#432 Injector improvements
...
- Separate FieldInjection from default fallback for no-Inject public no-args constructor classes
- Make CommandInitializer a normal, instantiable service
- Add various injections instead of fetching through command service
2016-05-08 11:15:56 +02:00
ljacqu
3fe2f0b6a8
Add missing test matcher
...
- Mock verifications need matchers on all parameters, or on none. Test fails otherwise
2016-05-04 18:40:06 +02:00
Gabriele C
7c52460c87
Merge branch 'pre-injector'
2016-05-04 18:03:33 +02:00
Gabriele C
1ea2f98727
Start working on #687
...
Next step: Future return of the async registration
2016-05-04 18:01:47 +02:00
Gabriele C
5ceabe2146
Cleanup
2016-05-04 17:26:58 +02:00
ljacqu
491dc06de4
Fix RegisterAdminCommand test verifying that online player is kicked
2016-05-02 19:57:54 +02:00
ljacqu
f76a68cb26
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-dependency-injection
...
Conflicts:
src/main/java/fr/xephi/authme/AuthMe.java
src/main/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommand.java
src/main/java/fr/xephi/authme/hooks/PluginHooks.java
src/main/java/fr/xephi/authme/listener/AuthMePlayerListener.java
src/main/java/fr/xephi/authme/listener/AuthMeServerListener.java
src/test/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommandTest.java
2016-05-02 19:48:12 +02:00
ljacqu
9af596327a
#432 Inject in commands: DataSource / AntiBot / PasswordSecurity / PlayerCache
...
- Inject the services instead of passing them through the command service
2016-05-02 18:52:34 +02:00
Xephi59
20a237dbdf
[DEV] This test would fail until player couldn't be returned as he was
...
kicked
2016-05-02 03:38:25 +02:00
ljacqu
e6dacd6951
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-dependency-injection
2016-04-30 12:17:33 +02:00
ljacqu
3c6415a6a4
#432 Use injector instantiate hash algorithms
2016-04-30 12:17:18 +02:00
ljacqu
908399e271
#432 Injector - prevent static field injection, add more tests
2016-04-30 10:44:32 +02:00
ljacqu
2c491803d3
Injector - disallow static PostConstruct methods, add more tests
2016-04-29 23:49:03 +02:00
ljacqu
7f44ecdb40
Create event consistency test + test code cleanup
2016-04-29 22:39:46 +02:00
ljacqu
8d489efffd
#683 Plaintext to SHA256: Add warning message + skip SHA hashes
...
- Add message not to stop the server before conversion finishes
- Skip hashes starting with $SHA$ during conversion
- Create unit tests
2016-04-29 21:58:32 +02:00
ljacqu
5963628fa6
#432 Add field injection to AccountsCommand
2016-04-27 22:59:44 +02:00
ljacqu
02079f1f5c
#432 Create custom dependency injector
2016-04-27 22:49:20 +02:00
ljacqu
59d3bc95c0
Move getOnlinePlayers() from Utils to BukkitService; delete Wrapper
2016-04-23 15:24:41 +02:00
ljacqu
a78e0408c6
#449 Remove use of legacy settings in encryption methods
2016-04-23 12:46:30 +02:00
ljacqu
71515f188a
#551 Email registration should fail if no server email is configured
...
- Stop registration and issue an error if the email address setting is empty for email registration
- Refactor register command into smaller portions
- Create tests
2016-04-15 14:37:47 +02:00
ljacqu
6074ba59d5
#654 Add test verifying nothing is sent for empty message
...
- Including various test simplifications
2016-04-15 12:27:34 +02:00
ljacqu
ca0cbe6caf
Code householding
...
- Move console initialization for tests into TestHelper
- Remove unused properties in legacy Settings
- Add issue number to TODO comments where applicable
2016-04-14 12:28:19 +02:00
ljacqu
3bb7ff2b85
#653 Empty salt column causes error when retrieving password
...
- Handle potentially empty salt column in MySQL and SQLite
- Create unit tests reflecting these cases
2016-04-14 11:48:24 +02:00
ljacqu
e2b50b72a5
Get player via BukkitService; add unit tests for commands
2016-04-08 19:56:44 +02:00