- Move expiring collections to util.expiring package - Change ExpiringSet to remove expired entries during normal calls
151 lines
5.1 KiB
Java
151 lines
5.1 KiB
Java
package fr.xephi.authme.data;
|
|
|
|
import fr.xephi.authme.ReflectionTestUtils;
|
|
import fr.xephi.authme.settings.Settings;
|
|
import fr.xephi.authme.settings.properties.SecuritySettings;
|
|
import fr.xephi.authme.util.expiring.TimedCounter;
|
|
import org.junit.Test;
|
|
|
|
import static org.hamcrest.Matchers.equalTo;
|
|
import static org.junit.Assert.assertThat;
|
|
import static org.mockito.BDDMockito.given;
|
|
import static org.mockito.Mockito.mock;
|
|
|
|
/**
|
|
* Test for {@link CaptchaManager}.
|
|
*/
|
|
public class CaptchaManagerTest {
|
|
|
|
@Test
|
|
public void shouldAddCounts() {
|
|
// given
|
|
Settings settings = mockSettings(3, 4);
|
|
CaptchaManager manager = new CaptchaManager(settings);
|
|
String player = "tester";
|
|
|
|
// when
|
|
for (int i = 0; i < 2; ++i) {
|
|
manager.increaseCount(player);
|
|
}
|
|
|
|
// then
|
|
assertThat(manager.isCaptchaRequired(player), equalTo(false));
|
|
manager.increaseCount(player);
|
|
assertThat(manager.isCaptchaRequired(player.toUpperCase()), equalTo(true));
|
|
assertThat(manager.isCaptchaRequired("otherPlayer"), equalTo(false));
|
|
}
|
|
|
|
@Test
|
|
public void shouldCreateAndCheckCaptcha() {
|
|
// given
|
|
String player = "Miner";
|
|
Settings settings = mockSettings(1, 4);
|
|
CaptchaManager manager = new CaptchaManager(settings);
|
|
String captchaCode = manager.getCaptchaCodeOrGenerateNew(player);
|
|
|
|
// when
|
|
boolean badResult = manager.checkCode(player, "wrong_code");
|
|
boolean goodResult = manager.checkCode(player, captchaCode);
|
|
|
|
// then
|
|
assertThat(captchaCode.length(), equalTo(4));
|
|
assertThat(badResult, equalTo(false));
|
|
assertThat(goodResult, equalTo(true));
|
|
// Supplying correct code should clear the entry, and any code should be valid if no entry is present
|
|
assertThat(manager.checkCode(player, "bogus"), equalTo(true));
|
|
}
|
|
|
|
@Test
|
|
public void shouldHaveSameCodeAfterGeneration() {
|
|
// given
|
|
String player = "Tester";
|
|
Settings settings = mockSettings(1, 5);
|
|
CaptchaManager manager = new CaptchaManager(settings);
|
|
|
|
// when
|
|
String code1 = manager.getCaptchaCodeOrGenerateNew(player);
|
|
String code2 = manager.getCaptchaCodeOrGenerateNew(player);
|
|
String code3 = manager.getCaptchaCodeOrGenerateNew(player);
|
|
|
|
// then
|
|
assertThat(code1.length(), equalTo(5));
|
|
assertThat(code2, equalTo(code1));
|
|
assertThat(code3, equalTo(code1));
|
|
}
|
|
|
|
@Test
|
|
public void shouldIncreaseAndResetCount() {
|
|
// given
|
|
String player = "plaYer";
|
|
Settings settings = mockSettings(2, 3);
|
|
CaptchaManager manager = new CaptchaManager(settings);
|
|
|
|
// when
|
|
manager.increaseCount(player);
|
|
manager.increaseCount(player);
|
|
|
|
// then
|
|
assertThat(manager.isCaptchaRequired(player), equalTo(true));
|
|
assertHasCount(manager, player, 2);
|
|
|
|
// when 2
|
|
manager.resetCounts(player);
|
|
|
|
// then 2
|
|
assertThat(manager.isCaptchaRequired(player), equalTo(false));
|
|
assertHasCount(manager, player, 0);
|
|
}
|
|
|
|
@Test
|
|
public void shouldNotIncreaseCountForDisabledCaptcha() {
|
|
// given
|
|
String player = "someone_";
|
|
Settings settings = mockSettings(1, 3);
|
|
given(settings.getProperty(SecuritySettings.USE_CAPTCHA)).willReturn(false);
|
|
CaptchaManager manager = new CaptchaManager(settings);
|
|
|
|
// when
|
|
manager.increaseCount(player);
|
|
|
|
// then
|
|
assertThat(manager.isCaptchaRequired(player), equalTo(false));
|
|
assertHasCount(manager, player, 0);
|
|
}
|
|
|
|
@Test
|
|
public void shouldNotCheckCountIfCaptchaIsDisabled() {
|
|
// given
|
|
String player = "Robert001";
|
|
Settings settings = mockSettings(1, 5);
|
|
CaptchaManager manager = new CaptchaManager(settings);
|
|
given(settings.getProperty(SecuritySettings.USE_CAPTCHA)).willReturn(false);
|
|
|
|
// when
|
|
manager.increaseCount(player);
|
|
// assumptions
|
|
assertThat(manager.isCaptchaRequired(player), equalTo(true));
|
|
assertHasCount(manager, player, 1);
|
|
// end assumptions
|
|
manager.reload(settings);
|
|
boolean result = manager.isCaptchaRequired(player);
|
|
|
|
// then
|
|
assertThat(result, equalTo(false));
|
|
}
|
|
|
|
private static Settings mockSettings(int maxTries, int captchaLength) {
|
|
Settings settings = mock(Settings.class);
|
|
given(settings.getProperty(SecuritySettings.USE_CAPTCHA)).willReturn(true);
|
|
given(settings.getProperty(SecuritySettings.MAX_LOGIN_TRIES_BEFORE_CAPTCHA)).willReturn(maxTries);
|
|
given(settings.getProperty(SecuritySettings.CAPTCHA_LENGTH)).willReturn(captchaLength);
|
|
given(settings.getProperty(SecuritySettings.CAPTCHA_COUNT_MINUTES_BEFORE_RESET)).willReturn(30);
|
|
return settings;
|
|
}
|
|
|
|
private static void assertHasCount(CaptchaManager manager, String player, Integer count) {
|
|
TimedCounter<String> playerCounts = ReflectionTestUtils
|
|
.getFieldValue(CaptchaManager.class, manager, "playerCounts");
|
|
assertThat(playerCounts.get(player.toLowerCase()), equalTo(count));
|
|
}
|
|
}
|