* #1561 Fix timing attacks by comparing hashes in constant time * #1561 Fix timing attacks in phpBB fallback hashes - As noted by @games647
42 lines
1.2 KiB
Java
42 lines
1.2 KiB
Java
package fr.xephi.authme.security.crypts;
|
|
|
|
import fr.xephi.authme.security.crypts.description.HasSalt;
|
|
import fr.xephi.authme.security.crypts.description.Recommendation;
|
|
import fr.xephi.authme.security.crypts.description.SaltType;
|
|
import fr.xephi.authme.security.crypts.description.Usage;
|
|
|
|
import static fr.xephi.authme.security.HashUtils.isEqual;
|
|
|
|
/**
|
|
* Common supertype of encryption methods that use a player's username
|
|
* (or something based on it) as embedded salt.
|
|
*/
|
|
@Recommendation(Usage.DO_NOT_USE)
|
|
@HasSalt(SaltType.USERNAME)
|
|
public abstract class UsernameSaltMethod implements EncryptionMethod {
|
|
|
|
@Override
|
|
public abstract HashedPassword computeHash(String password, String name);
|
|
|
|
@Override
|
|
public String computeHash(String password, String salt, String name) {
|
|
return computeHash(password, name).getHash();
|
|
}
|
|
|
|
@Override
|
|
public boolean comparePassword(String password, HashedPassword hashedPassword, String name) {
|
|
return isEqual(hashedPassword.getHash(), computeHash(password, name).getHash());
|
|
}
|
|
|
|
@Override
|
|
public String generateSalt() {
|
|
return null;
|
|
}
|
|
|
|
@Override
|
|
public boolean hasSeparateSalt() {
|
|
return false;
|
|
}
|
|
|
|
}
|