Meishin/LoginSystem
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
3,524 Commits 10 Branches 53 Tags
26472b6be32e924813f61841b90087ae46a2ea66
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ljacqu 26472b6be3 #1539 Create common parent for SQLite and MySQL 2018-03-25 22:27:44 +02:00
ljacqu 4595a14191 #1539 Add support for columns that are not on player auth (is_logged, has_session) 2018-03-25 11:52:40 +02:00
ljacqu 137fc3d505 #1539 Use columns handler in more datasource methods; fix case-insensitivity for SQLite 2018-03-24 22:53:30 +01:00
ljacqu 881ef6a640 #1539 DataSource columns: close MySQL connections, add missing columns, use newly built-in types, improve column initialization 2018-03-24 21:16:43 +01:00
ljacqu 5a58f2c44f #1539 Integrate data source columns library 
- Create wrapper around SqlColumnsHandler for AuthMe-specific behavior
- Integrate columns handler into first SQLite and MySQL method implementations
 2018-03-24 12:24:43 +01:00
ljacquandHexelDev a1a909c01d #1531 Move spigot detection to BukkitService (#1534) 2018-03-19 23:08:48 +01:00
ljacquandGitHub 250bd0d148 Merge pull request #1517 from AuthMe/642-kick-on-fast-commands 
#642 - Quick Command Protection
 2018-03-19 22:35:49 +01:00
ljacqu fddb3bf265 Fix minor Checkstyle violations 
- Mostly missing JavaDoc, some line lengths
 2018-03-11 19:08:21 +01:00
ljacqu ff0a7e1f89 Fix failing test 2018-03-11 16:34:25 +01:00
ljacqu 15f49dcbb3 Merge branch 'global-replacements' 2018-03-10 16:59:56 +01:00
ljacqu 1a53cd11b2 #829 Move CommandSender / name to first argument to avoid confusion with varargs 
- Overloaded method with (String, String...) as args was problematic as it could be confusing on its own and also confusing with the (CommandSender, String...) flavor
 2018-03-10 16:58:30 +01:00
ljacqu 8d5afa7fbc Minor: Use CommonService for permission lookup 
- Some changes found in a very old patch :) - drop injection of PermissionsManager in favor of CommonService
- Rename IsEqualByReflectionMatcher's method to something more specific to differentiate it better from Hamcrest's equalTo() matcher
 2018-02-23 23:37:24 +01:00
ljacquandGitHub 329657bd5f #1497 Show specific message for invalid YAML files (#1506) 
* #1497 Throw dedicated exception for invalid YAML files and handle it on startup
- Wrap SnakeYAML exceptions when loading config.yml and commands.yml on startup into own exception type
- Handle exception type on startup with specific error message

* #1497 Fix inaccurate JavaDoc comment
 2018-02-23 23:31:22 +01:00
ljacqu 7864bb06ac Minor cleanups 
- Fix line length violations
- Add JavaDoc to some longer methods
- Remove unused imports
 2018-02-23 23:23:24 +01:00
ljacqu 83e247afe9 Minor: Simplify check for Spigot 2018-02-17 23:23:44 +01:00
ljacqu 90400650c3 Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 1467-message-keys-hierarchy 2018-02-17 23:08:39 +01:00
ljacqu 9dd4039fdd #1467 Create backup before migrating; output newly added message keys 
- Extract logic for creating a backup timestamp into FileUtils
 2018-02-13 22:15:03 +01:00
ljacqu ffeb04c0a2 Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 1467-message-keys-hierarchy 
Conflicts:
	src/main/resources/messages/messages_ko.yml
 2018-02-11 09:47:07 +01:00
ljacqu 189647d9f2 #1467 Fix character issues by always using UTF-8 when reading and writing 
- Change usages of Bukkit's FileResource to a ConfigMe PropertyReader
- Specify UTF-8 for reading and writing
 2018-02-11 09:22:42 +01:00
ljacqu cd61febd76 #1467 Change /authme messages to only update help text file now 2018-02-02 20:12:42 +01:00
ljacqu 1d6d9eb764 #1467 Rearrange old keys migration so no entries get lost 
- 'error' was an old entry but now we have multiple entries under 'error' (which is now a section), so we need to ensure that we migrate the old 'error' entry before the migration sets anything under that path
 2018-02-02 19:40:28 +01:00
ljacqu f44353ed4c #1467 Fix messages verification tool task + remove empty messages in YML files 2018-02-01 23:09:08 +01:00
ljacqu f67ddb0c77 #1467 Migrate all message files, make sure migrater keeps predefined order 2018-02-01 20:23:06 +01:00
ljacqu b72fe1b1a9 Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 1467-message-keys-hierarchy 2018-01-31 22:09:59 +01:00
ljacquandGitHub e50a1e26e4 Update ISSUE_TEMPLATE.MD 2018-01-30 22:15:07 +01:00
ljacqu abd19cdb86 #1467 Fix error in placeholder migration, create and fix tests 2018-01-29 22:15:39 +01:00
ljacqu 760a2a909c #1467 Fix export issues (style, encoding) 
- Override yaml file resource to ensure that lines aren't wrapped
- Override yaml file reader to ensure the file is always read as UTF-8
 2018-01-29 21:46:58 +01:00
ljacqu f714e9d564 #1467 Change message keys and messages_en to new structure 2018-01-29 20:56:30 +01:00
ljacqu dfe47066cd Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 1467-message-keys-hierarchy 2018-01-29 20:04:38 +01:00
ljacqu 1eaf321575 #1467 Try to clean up abstract message file handler hierarchy 
- Move some handling with the default file configuration down to the help message file handler since it is the only one with such a behavior now
 2018-01-25 21:48:48 +01:00
ljacqu 820e443b81 #1467 Implement messages file migration 
- Create messages updater called when a messages YML file is loaded
  - Work in progress
- Does not yet include changes to any message keys
 2018-01-24 22:19:25 +01:00
ljacqu b3a191d7e2 Minor: simplify CheckMessageKeyUsages task and make check more strict 2018-01-22 19:56:51 +01:00
ljacqu 6f2c586441 Test initialization of permission handlers in PermissionManager 2018-01-21 22:11:47 +01:00
ljacqu acaaf6fe41 Minor dependency updates 
- JaCoCo 0.8.0 brings some interesting exclusions in code coverage, which means we might be able to drop TestHelper#validateHasOnlyPrivateEmptyConstructor soon
 2018-01-21 21:01:23 +01:00
ljacqu 610a699c95 Refactor message handlers into injectable components (preparation for #1467) 2018-01-21 20:47:29 +01:00
ljacqu 847991b658 #1474 Don't log /email changepassword command (exposes password) 2018-01-21 19:06:51 +01:00
ljacqu 761ee2f05b #1035 Migrate other accounts config from config.yml to commands.yml 2018-01-21 18:58:20 +01:00
ljacquandGitHub 1e16f251ef Merge pull request #1477 from AuthMe/1035-handle-alt-accounts-in-commandsYml 
1035 handle alt accounts in commands yml
 2018-01-17 21:49:29 +01:00
ljacqu fe4ea6d22b Remove migration of commands from config.yml to commands.yml 
- Migration was shipped with the 5.2 release and is now becoming harder to maintain; since it's quite old we drop it
 2018-01-17 21:42:17 +01:00
ljacqu 7f77f30439 Minor: Fix forgotten param documentation in JavaDoc 2018-01-16 20:40:21 +01:00
ljacqu f19f8502d8 #1035 Forced commands: add more tests, rename account constraints, update commands.yml comments 2018-01-16 20:32:17 +01:00
ljacqu 3c0236e15e #1035 Fix handling of new login command constraints 
- Incorporate ConfigMe fix
- Various fixes in the integration
 2018-01-15 22:39:29 +01:00
ljacqu 8dbba1dc93 #1035 Add optional constraints to onLogin and onFirstLogin commands for number of alt accounts 
- Extend Command to add specific constraints
- Currently doesn't work because of missing ConfigMe support
 2018-01-14 12:23:04 +01:00
ljacqu 1cd5a6acce #1472 Add zhtw translation changes by @haer0248 2018-01-14 11:16:23 +01:00
ljacqu d9c1af4311 #1454 Run other accounts command in sync mode 2018-01-08 23:08:37 +01:00
ljacqu a29738e2a8 #1460 Fix null handling in recent players command 
- Last login might be null
 2018-01-06 20:26:07 +01:00
ljacqu ea87075cd2 #930 Add specific message for register captcha success 2018-01-06 20:01:45 +01:00
ljacqu 9afd8679e9 Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 930-captcha-for-register 2018-01-06 19:04:14 +01:00
ljacqu 23c246748a #930 Register captcha: avoid circular dependency by handling limbo message in captcha command 
- Set limbo message in captcha command (as is done for login captcha)
- Add clarifying comments to captcha command
- Remove classes handling circular dependencies
 2018-01-06 19:04:03 +01:00
ljacqu 94cf310d5b Minor: fix code climate config test 2018-01-06 18:06:30 +01:00
ljacqu 99ef874327 Update CodeClimate configuration to new structure 2018-01-06 11:48:27 +01:00
ljacqu 84b376d2a5 #930 Change captcha storage to change code internally upon failure 
- Within CaptchaStorage#checkCode, a player's captcha code is overridden with a new one on failure or cleared on success
- Fixes inconsistencies in the retrieval / regeneration of codes
 2018-01-06 02:31:26 +01:00
ljacqu 180bbbf0be #930 Refactor captcha managers to have a crude captcha storage class instead of inheritance 
- Remove abstract captcha manager in favor of a primitive captcha code storage (composition over inheritance)
- Supply player when checking captcha code for further usage (fixes open point from previous commit)
 2018-01-05 01:26:25 +01:00
ljacqu 0494886518 Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 930-captcha-for-register 2018-01-05 00:17:39 +01:00
ljacqu 7cf3f6d77b #930 Registration captcha: update message shown to player on failed captcha 
- Show message with new captcha code when a captcha has failed
- Requires implementation of circular dependency handler (initial draft)
 2018-01-05 00:17:22 +01:00
ljacqu c8d82a23e0 Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 930-captcha-for-register 2017-12-22 21:54:58 +01:00
ljacqu 8bae71e1bd #1435 Send password recovery emails in async 2017-12-21 21:54:23 +01:00
ljacqu 1a60036592 #930 Extract common captcha functionality into abstract superclass 
- Create AbstractCaptchaManager
- Add tests
 2017-12-01 23:40:20 +01:00
ljacqu 33904c09e9 #930 Create registration captcha manager 
- Introduce registration captcha manager, rename login captcha manager accordingly
- Integrate reg. captcha manager into /register command

Open points:
- Refactor common captcha functionality into abstract superclass
- If captcha before /register necessary, show appropriate message to player immediately
- Unit tests
 2017-12-01 21:12:35 +01:00
ljacqu 67a6a42dfe Minor Javadoc fix: one "yet" is enough :) 2017-12-01 20:33:33 +01:00
ljacqu 058ac22462 Update docs 2017-12-01 19:16:49 +01:00
ljacqu c784fc7f2e #1423 Fix ignored review remarks 2017-11-29 19:43:35 +01:00
ljacqu f1c1848985 #1046 Add onFirstLogin to commands.yml 
- Allow to configure commands run on player's first login (login of player with a previously null lastlogin date)
 2017-11-28 21:41:30 +01:00
ljacqu 50dbbb8d87 #1254 Create command to see recently logged in players 
- Create datasource method to fetch most recent players by last login date
- Add command to view last logged in players
 2017-11-28 21:07:10 +01:00
ljacqu 7932c1bf90 Update to injector 1.0 
- Includes Factory and SingletonStore so our custom implementation is removed
 2017-11-25 21:27:18 +01:00
ljacqu 86a07771d7 Open 5.5 development iteration 2017-11-25 14:41:23 +01:00
ljacqu 6365926cf0 Fix test in AntiBotServiceTest 2017-11-23 20:06:21 +01:00
ljacqu 53f7bf155f Fix wrong check in CodeClimateConfigTest 2017-11-23 18:13:17 +01:00
ljacqu 1053440b15 Refactor util for setting BukkitService mock behavior 
- Move helper methods for setting BukkitService mock behavior into their own class
- Change methods to use Mockito's answer instead of verification + argument capture -> calling the methods now belongs to the test setup (given clause) and allows the behavior to take effect more than once
 2017-11-22 00:24:11 +01:00
ljacqu 4717dc148c #1413 Don't run onUnregister command in async 2017-11-21 23:48:15 +01:00
ljacqu c693901330 Merge branch '1400-phpbb-hash' of https://github.com/AuthMe/AuthMeReloaded 2017-11-04 11:32:44 +01:00
ljacqu 5c40cb3b73 Insert null email as DEFAULT so column default may take effect 
Ugly implementation to fit into AuthMe 5.4. If email on PlayerAuth is null, do not supply NULL as the email value but use DEFAULT instead so that the default value is used if present in the column configuration.
 2017-11-04 11:29:21 +01:00
ljacqu 7d6c61258b Fix #1401 bungeecord message sent even if disabled 2017-11-04 10:17:52 +01:00
ljacqu 80ab41ae5a #1400 Sync AuthMe's phpBB hash implementation with phpBB3's 
- phpBB3 seems to favor using BCrypt $2y$ now
- Keep unsalted MD5 and phpass salted MD5 comparisons for backwards compatibility
 2017-11-04 09:58:51 +01:00
ljacqu c7ba06e2b9 Fix test / use new DataSource method / add space before keywords 2017-11-03 19:57:40 +01:00
ljacqu 44a7baff9a #1350 Add option to force using the sync PlayerLoginEvent 
- Introduce new configuration (taken from @sgdc3)
- Create JoiningPlayer, based on a Player object or String name, determining how permissions will be checked
 2017-11-01 21:02:22 +01:00
ljacquandGitHub e3dd719b0e #792 Migrate last IP column if is NOT NULL without default value (#1385) 
- Move MySQL migrations into a separate class
- Add migration for last IP column to be nullable if it has a not null constraint without a default value
 2017-10-29 07:52:11 +01:00
ljacqu 2c6181d150 Add missing tests for API package 2017-10-28 23:15:53 +02:00
ljacqu b687c68d46 Create test for HelpTranslationGenerator 2017-10-28 19:36:35 +02:00
ljacquandGitHub 8127d70058 Merge pull request #1386 from AuthMe/1367-mysql-notNull-toggle 
Improve MySQL not null toggle / authme debug commands output
 2017-10-28 18:49:23 +02:00
ljacqu 20ca4f9dc9 #1368 Improve the look of /authme debug 
- Add a colored title for each command execution within /authme debug
- Fit more texts on one line
 2017-10-28 17:19:47 +02:00
ljacqu c6fbc1187f #1367 MySQL not null changer: List 'not null' and default values separately 
- Check not only for NOT NULL constraint but also if a column has a default value
- Use suffixes instead of colors only so the command is usable via console
 2017-10-28 15:41:16 +02:00
ljacquandGitHub 04c5224e99 #1190 Show settings warnings on reload also (#1384) 
- Extract setting checks into their own class, called on startup and reload
 2017-10-28 14:15:38 +02:00
ljacqu d40109929c Fix describeHashAlgos tool task 
- Handle case when Argon2 library is not loaded
- Account for hash algorithms with `null` as associated impl. class
 2017-10-28 13:40:06 +02:00
ljacqu fbd8049af5 Minor: Make email check in '/email change' case-insensitive 2017-10-28 13:10:24 +02:00
ljacqu 78e2763984 Help translations: remove entry for /authme purge second argument (no longer exists) 
- Remove unknown entries as found by the verifyHelpTranslations tool task
 2017-10-22 09:51:32 +02:00
ljacqu 07b4309340 Readme: fix team link and mention of now deprecated hashes 2017-10-22 09:37:49 +02:00
ljacqu b211c97395 Minor: delete PlainText implementation 
- It never gets used anymore and could cause security issues if we did accidentally use it as EncryptionMethod
 2017-10-22 09:27:03 +02:00
ljacquandGitHub d6e2369f36 #792 Force migration of SQLite when necessary (#1371) 
- Detect if a migration is necessary
- Create a backup
- Perform the migration
 2017-10-22 09:16:48 +02:00
ljacqu c37c0ce436 Fix CodeClimate config test to account for new test exclusion entry 2017-10-21 19:55:56 +02:00
ljacqu 6cf2535109 Exclude test classes from Checkstyle checks 2017-10-21 19:51:48 +02:00
ljacqu 4e8deec258 Move #isNpc method to PlayerUtils 
- After dropping our hook to CombatTagPlus it is not relevant for it to be in PluginHooksService anymore
 2017-10-21 12:08:23 +02:00
ljacqu 58657f5d3f Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 792-add-registration-date-and-ip 2017-10-21 10:46:17 +02:00
ljacqu 1651a61063 #792 #814 Implement SQLite migration, allow last IP to be nullable in MySQL 
- Old SQLite setups have the last IP column as NOT NULL but without a default value. With the new concept (where we don't set a last IP on player registration) it fails.
  - Create an /authme debug child that allows to migrate SQLite (tricky because SQLite does not support dropping or modifying columns)
  - Allow last IP column to be NOT NULL in MySQL as well (extend MySQL /authme debug child)
- Add TODO comments with follow-up issue to extend our commands with new registration IP field
 2017-10-21 10:45:48 +02:00
ljacqu b5ea48085c #792 DataSource: when creating registrationDate column, set all rows to the current date 2017-10-20 21:31:58 +02:00
ljacqu a425eacf2d #792 Add missing tests / fix CodeClimate issues 2017-10-20 17:49:30 +02:00
ljacqu ea824ea3f0 #1016 Update hash algorithms list, add test that Deprecated annotation is in sync between enum and hash impl. class 2017-10-19 21:52:55 +02:00
ljacqu fca77b940f #1016 Deprecate MD5, SHA1, SHA512: no longer allowed for active use 
- Deprecate unsalted hashes: if such a hash is configured, move it to the legacy hashes setting to still support the existing hashes in the database but hash all passwords from now on with our default, SHA256.
 2017-10-19 21:30:19 +02:00
ljacqu 7d445217d6 Merge redundant ConsoleLogger#debug overloads 
- No need to distinguish between String[] and Object[] because log4j only has methods for Object[]
 2017-10-19 20:14:17 +02:00
ljacqu 90073ef95d Merge branch 'master' of https://github.com/AuthMe/AuthMeReloaded into 792-registration-date-and-ip 
Conflicts:
	src/main/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommand.java
	src/main/java/fr/xephi/authme/datasource/Columns.java
	src/main/java/fr/xephi/authme/datasource/SQLite.java
	src/main/java/fr/xephi/authme/process/join/AsynchronousJoin.java
	src/main/java/fr/xephi/authme/service/SessionService.java
	src/main/java/fr/xephi/authme/settings/properties/DatabaseSettings.java
	src/test/java/fr/xephi/authme/service/SessionServiceTest.java
	src/test/resources/fr/xephi/authme/datasource/sql-initialize.sql
 2017-10-15 23:45:41 +02:00