ljacqu
8eb1b38d21
Slim down CommandParts API
...
- Remove all methods that aren't constructors / fancy get() on list; almost possible to remove class entirely
2015-12-04 23:47:48 +01:00
ljacqu
2faad44ffa
Move most API of CommandParts to util classes
...
Gradual transition to removing CommandParts altogether.
- Move logic from CommandParts to utils classes
2015-12-04 23:19:37 +01:00
ljacqu
9140ebe602
Change initialized command descriptions to Set
...
- Set is more efficient if it's frequently used for `contains()`, which is what we use it for after initialization
2015-12-04 21:58:16 +01:00
ljacqu
c78e12de04
Refactorings - prepare to remove FoundCommandResult
...
- Reduce tight coupling by passing list of available commands as param to CommandHandler
- Split command processing method into several smaller ones
- Remove unfinished logic for unlimited command arguments (reason: was not implemented and not used, probably needs another way to handle it once the need for it arises)
- Create test for CommandHandler
2015-12-04 21:33:50 +01:00
ljacqu
0c1589f93a
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into command-perms-refactor
2015-12-04 19:35:57 +01:00
Xephi
8336dc848e
Fix #301
2015-12-04 17:24:56 +01:00
ljacqu
152a0cabb5
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into command-perms-refactor
...
Conflicts:
src/main/java/fr/xephi/authme/command/CommandInitializer.java
2015-12-03 22:16:52 +01:00
ljacqu
1fbe4e0c3b
#298 Change password shows wrong 'pw cant be username' error
...
- Change MessageKey to the proper message
- Change permissions for admin changepassword to admin
- Rename player changepassword command arguments to reflect their actual meaning
2015-12-03 22:07:18 +01:00
ljacqu
1ca6bcffe1
Make AuthMe.management private; create test for CaptchaCommand
2015-12-02 22:13:43 +01:00
ljacqu
c288d3285e
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into command-perms-refactor
2015-12-01 21:59:19 +01:00
ljacqu
690a8d67a3
Abstract Messages into two layers; move to new 'output' package
...
- Abstract Messages into two layers: the top layer 'Messages' is how Messages can be retrieved and sent as before. In the background, package-private, MessagesManager actually does the file read and worries about I/O while Messages takes care of higher-level things (such as joining two lines or checking the current language).
2015-12-01 21:45:02 +01:00
ljacqu
54d8ede5bc
Add changes missed during merge
2015-12-01 20:44:44 +01:00
ljacqu
c4df2589b7
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into command-perms-refactor
...
Conflicts:
src/main/java/fr/xephi/authme/command/CommandDescription.java
src/main/java/fr/xephi/authme/command/CommandInitializer.java
2015-12-01 20:43:49 +01:00
Tim Visée
ccb9e24ce5
Fixed invalid permission reference.
2015-12-01 16:35:28 +01:00
Tim Visée
4afef9714d
Converted two commands to use the builder
2015-12-01 16:24:24 +01:00
Tim Visée
fdc747d007
Refactored player permissions enum, to make the name suit better
2015-12-01 16:19:05 +01:00
Tim Visée
8bea153005
Rebased administration command permission nodes
2015-12-01 16:17:37 +01:00
Tim Visée
3b9b1b7b8a
Refactored name of command builder, to specify it a little better
2015-12-01 16:14:59 +01:00
ljacqu
485b6934e6
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into command-perms-refactor
2015-11-30 21:12:47 +01:00
ljacqu
a4c45e126e
Start refactoring of command handling (work in progress)
...
Preparation:
- Remove unused API
- Move some logic from "data classes" elsewhere
2015-11-30 21:09:52 +01:00
Gabriele C
109c85f4dd
Auto build number + helpHeader config
2015-11-29 14:27:44 +01:00
ljacqu
da0c5d1ea2
Split command management into initializer and handler
...
- Create Initializer class that only initializes AuthMe commands
- Move remaining method to CommandHandler
- Deprecate constructors on CommandDescription in favor of the builder
- Various cleanups and comments
2015-11-29 12:51:11 +01:00
ljacqu
d7513ecc7b
Fix nullpointer when command requires no permissions
...
- Add test to verify connections among the command initialization
2015-11-29 12:04:01 +01:00
ljacqu
7c652feac2
Fix failing command tests
...
- Detailed description missing period
- Fix twice defined /authme delete
- Add executable command to HelpSyntaxHelperTest initializations
- Remove unneeded constructors in CommandDescription
2015-11-29 10:56:01 +01:00
ljacqu
6a94135f64
Commands - fix child not being registered in parent via Builder
...
- Create test to ensure that commands don't define the same binding
- Create stricter attribute validation in builder: throw an error if required field was not initialized
2015-11-29 10:24:32 +01:00
ljacqu
a124e8f283
Refine CommandDescription builder; add/fix JavaDoc; add tests
...
- Add tests to check the integrity of the commands that are defined in the CommandManager
- Convert some more commands registrations to the new Builder format
2015-11-29 01:21:48 +01:00
ljacqu
faf9a2c8ac
Create builder for command description; refactor command classes
...
- Create builder class for CommandDescription
- Remove redundant methods in command registration classes (e.g. certain validation is superfluous because we only instantiate the classes internally)
- Replace multiple occurrences where a field is directly instantiated e.g. with a list and then its value is overwritten by a constructor = redundant instantiation of objects
2015-11-28 23:59:04 +01:00
ljacqu
364583e7db
Change use of String permissions to the permission enums
2015-11-28 21:59:29 +01:00
ljacqu
a1a14aa760
Add methods to Reflection utils; test ChangePasswordCommand fully
2015-11-28 20:40:02 +01:00
ljacqu
b916a38d80
Fix UtilsTest and replace the last test setups not to use reflections
2015-11-28 17:13:33 +01:00
DNx5
67244d5e7b
Fix admin register command lowercase the password.
2015-11-28 04:01:51 +07:00
ljacqu
210b691353
Testing - change to non-reflection WrapperMock test setup
...
Replaced many classes to use Wrapper to get singletons and replaced the test setups to use the WrapperMock instead of setting fields through reflection
2015-11-26 22:53:12 +01:00
ljacqu
93cddb7a5c
Merge enum branch into master
2015-11-26 21:45:06 +01:00
Tim Visée
eb07d9787d
Fixed duplicate code, removed warning suppresion, reformatted code
2015-11-26 21:04:19 +01:00
DNx5
7a78b321e7
refactor all class to use the message key for sending messages.
2015-11-26 10:18:53 +07:00
DNx5
2de0e0e819
Set classes to use Messages getter in plugin instance.
2015-11-26 08:17:19 +07:00
ljacqu
644f7e8541
Merge origin/enum into local branch
2015-11-25 22:18:21 +01:00
ljacqu
d2b3d416a9
Change calls to Messages to use the MessageKey enum
2015-11-24 23:27:28 +01:00
Gabriele C
28e742e42f
cleanup
2015-11-24 19:04:18 +01:00
Gabriele C
cc8401e841
Move the antibot management
2015-11-24 18:51:09 +01:00
DNx5
8e9bfc6299
update playerloginevent and some listener.
...
i hope it will fix the lag issues.
2015-11-24 07:15:58 +07:00
DNx5
b4b92e5a93
reordering local variable scope in captcha command
2015-11-24 05:46:28 +07:00
Tim Visée
82bf0f45ca
Finalized some fields, removed redundant code, various other fixes
2015-11-23 22:14:03 +01:00
Tim Visée
47b1d00ccf
Fixed various spelling and grammar issues
2015-11-23 22:07:32 +01:00
Tim Visée
36c50c4507
Reformatted code with new code style
2015-11-23 21:46:34 +01:00
Tim Visée
2e868c7492
Reformatted all code files, cleaned up the project
2015-11-23 21:33:08 +01:00
AuthMe-Team
9ec2d6d059
Stuff from the common floobits workspace
...
Author: AuthMe-Team <AuthMeTeam@123NoEmail.com>
2015-11-23 20:23:52 +01:00
ljacqu
e456203fc6
Refactor Utils#getOnlinePlayers and add background info
2015-11-22 01:30:07 +01:00
ljacqu
cd728b569e
Create test for CommandManager; fix javadoc in CommandDescription
2015-11-21 22:32:16 +01:00
Gabriele C
579c51f4a2
Remove the old Vault group management system. (THIS COMMIT BREAKS THE COMPILATION)
2015-11-21 20:16:07 +01:00