ljacqu
a0da423a7b
Minor - Javadoc changes
...
- Add/replace/improve javadoc in the commands and encryption section
- Note: A simple <p> is the javadoc way to make a new paragraph
http://www.oracle.com/technetwork/java/javase/documentation/index-137868.html#format
- Note: Do not escape '<' and '>' inside of {@code }
- Note: '>' does not need to be escaped
2015-12-31 13:32:41 +01:00
Xephi59
e1a84448a2
Fix the whole Javadoc syntax
2015-12-31 01:06:09 +01:00
ljacqu
c0a393b8b3
Minor - rename EncryptedPassword to HashedPassword
...
- We hash passwords; we don't encrypt them
2015-12-30 22:51:59 +01:00
ljacqu
e85dbe81e5
#358 Ensure lowercase player name, issue cleanup
...
- Ensure within PasswordSecurity that the player name is lowercase
- Remove check for MD5VB separate salt (we only generate hashes with the salt embedded, so either we need to change that or we don't need this check)
- Remove obsolete TODO
2015-12-30 22:45:18 +01:00
Gabriele C
300a621e1c
cleanup
2015-12-30 22:28:45 +01:00
ljacqu
8b60c66cc8
Minor - adjust PlayerAuth builder methods
...
- Rename hash() to password()
- Add location(Location) builder method
- Replace usages of password(new EncryptedPassword(hash, salt)) to the more terse password(String, String) builder method
2015-12-30 18:28:06 +01:00
ljacqu
a3402d573f
#358 Handle hash + salt as one "unit"
...
- Rename HashResult to EncryptedPassword to reflect its broader use
- Use EncryptedPassword in methods that require the hash and the salt, instead of passing them as strings separately
- Store EncryptedPassword as field in PlayerAuth; updatePassword() thus processes the entire data in the EncryptedPassword object
2015-12-30 17:56:22 +01:00
ljacqu
531327dd9b
Minor - make AuthMe.database private
...
- In favor of AuthMe.getDataSource()
2015-12-29 11:55:57 +01:00
ljacqu
b3b751920a
#358 Replace usage of static PasswordSecurity methods
...
- Replace static methods to instance methods
- Use PlayerAuth builder instead of constructor
2015-12-29 00:13:20 +01:00
ljacqu
31730699ac
#358 Start refactoring PasswordSecurity
...
- Add new methods temporarily to NewEncrMethod interface
- No data source access within EncryptionMethod implementations
- Generate the salt within the EncryptionMethod implementation
- Deprecate static methods on PasswordSecurity
- Adjust AbstractEncryptionMethodTest to test the classes with the new interface
- Add getter for data source instead of accessing field directly
2015-12-28 16:23:08 +01:00
ljacqu
6ac1967364
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 358-encryptn-mthd-refactor
2015-12-28 13:33:18 +01:00
Xephi
c94b6223a1
Add wildcard to perform reset position for each players
2015-12-28 11:50:16 +01:00
ljacqu
513ff9a928
#358 Make RandomString static & generate all rand. strings with it
...
- Remove dubious random String generator on HashUtils
- Make further hash classes use HashUtils
2015-12-27 22:16:16 +01:00
ljacqu
2bb386c488
Merge master into 306-commands-service - Conflicts
2015-12-26 21:33:53 +01:00
ljacqu
103ebb44f0
Merge master into 306-commands-service
...
Conflicts:
- AuthMe
- CommandInitializer
- ConverterCommand
2015-12-26 21:33:25 +01:00
ljacqu
47e97244a7
#306 Create tests for CommandService and PlayerCommand
2015-12-26 20:58:05 +01:00
ljacqu
27fee3ca64
#306 Create PlayerCommand abstract type
...
- Create PlayerCommand to handle player-only command checks centrally and consistently
- Adjust tests
2015-12-26 19:47:47 +01:00
ljacqu
74ceb66430
#306 Remove singleton getters in admin commands
...
- Note: this commit does not remove all singleton getters
2015-12-26 17:57:53 +01:00
Xephi59
41e400e9dd
Deprecate flatile datasource, force flat to sqlite conversion #344
2015-12-26 15:38:16 +01:00
ljacqu
283bb7c113
Minor - add change lost during merge
2015-12-26 13:05:43 +01:00
ljacqu
c73969256c
Merge master into '306-command-service'
...
Conflict:
- HelpCommand.java
2015-12-26 13:01:00 +01:00
ljacqu
418fbabcc8
Fix #376 Check not to show alternatives for base command
...
- Fix wrong assumption in HelpCommand that the incoming arguments size always corresponds to the label count of the mapped command
2015-12-24 15:47:05 +01:00
ljacqu
9e8f51c616
#306 Fully test HelpProvider and CommandSyntaxHelper
2015-12-24 15:26:25 +01:00
ljacqu
cb2ffca6d3
#306 Change help provider to non-static / add calls to help functionality
2015-12-23 23:51:39 +01:00
ljacqu
a9fc658db0
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 306-command-service
2015-12-23 18:09:21 +01:00
ljacqu
14f6ecd716
#306 Adjust ExecutableCommand implementations to interface
2015-12-23 14:55:04 +01:00
ljacqu
8ef1b2ae3e
#306 Add command service and set up constructor dependency injection
...
(work in progress)
- Pass all dependencies via constructor
- Encapsulate command handling more (e.g. split CommandHandler with new CommandMapper)
- Add help command to all base commands at one central point
See AccountsCommand or HelpCommand for an example of the advantages - all necessary functions come from CommandService; objects aren't retrieved through a singleton getInstance() method anymore
2015-12-23 14:54:45 +01:00
ljacqu
857042ba5f
Minor - mark password confirmation as optional for /register
2015-12-23 12:39:48 +01:00
Gabriele C
8bfb56f34e
fix blindness when timeout = 0
2015-12-23 11:51:06 +01:00
Xephi59
cc67d6daea
Update Changepassword command
2015-12-23 00:44:03 +01:00
Xephi
644ffe954d
[DEV] [NEED TEST] Implement OAuth2 authentification to mail recovery!
2015-12-21 17:03:12 +01:00
Xephi
37eedfde62
Add a way to convert SQLite to MySQL (/converter sqlitetosql)
2015-12-21 15:43:36 +01:00
ljacqu
efa458cae1
Finalization for #305 - command refactor
2015-12-19 20:25:12 +01:00
ljacqu
3cc35baa5e
Merge master into commands-refactor
2015-12-19 18:26:40 +01:00
ljacqu
b64b6177fa
Fix invoking help command throwing exception
...
- ConcurrentModificationException was being thrown because labels was being modified again in transformForHelpCommand
2015-12-19 17:45:58 +01:00
ljacqu
a928a4092d
#305 Fix label handling, add extensive tests for command handler
2015-12-19 16:27:00 +01:00
ljacqu
42c34c56a0
Fix command formatting after refactor
...
- Fix spacing issues (too few or too many spaces)
- Handle base commands with invalid arguments properly
- Add highlighting function for command syntax
2015-12-19 12:20:52 +01:00
ljacqu
bf9724dd34
Fix label handling issues after reformatting
...
- Pass the correct arguments to HelpCommand
- Fix minor formatting / conditional check issues
2015-12-19 10:35:02 +01:00
ljacqu
01a294a334
#305 Adjust behavior of label handling; cleanup
...
- Fix bugs in behavior (wrong labels being shown for help)
- Change order of labels and arguments in FoundCommandResult constructors
- Move FoundResultStatus enum to its own class
- Create test class for HelpProvider
2015-12-18 22:19:26 +01:00
Gabriele C
7e6abf0441
Clean permission/group providers
2015-12-18 17:10:57 +01:00
ljacqu
d871939793
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into commands-refactor
...
Conflicts:
src/main/java/fr/xephi/authme/command/CommandUtils.java
src/main/java/fr/xephi/authme/command/executable/captcha/CaptchaCommand.java
2015-12-17 22:32:26 +01:00
ljacqu
cbf0996197
Logic for FoundCommandResult.Status / Add tests for CommandHandler
...
- Fix other tests
- Add logic for smaller pending FIXME's
2015-12-17 22:23:43 +01:00
ljacqu
dcc365c22f
Fix #349 Create method on Messages to pass tag replacements
...
- Add tests
- Fix placeholder in some files
2015-12-16 20:46:40 +01:00
ljacqu
282f777311
#336 Create command list generator in tools
...
- Add new conditional template tags [...] blabla [/...]
- Create logic for generating a list of commands
2015-12-14 21:07:03 +01:00
DNx5
7383242599
Attempt to fix #339
2015-12-13 23:07:58 +07:00
ljacqu
3e928cddf0
CommandInitializer - consistent indent and setter order
2015-12-13 10:49:15 +01:00
ljacqu
c48c56f08c
Change to new HelpProvider, adjust classes to new methods
2015-12-13 10:12:54 +01:00
ljacqu
01cba2a508
#315 #305 Refactor HelpProvider - add bit flags, reduce duplication (wip)
2015-12-12 22:50:07 +01:00
ljacqu
d26cbfbd14
Use Guava for CommandDescription builder validation
2015-12-12 22:28:05 +01:00
ljacqu
4d8d9de733
Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into commands-refactor
...
Conflicts:
src/main/java/fr/xephi/authme/command/executable/authme/AccountsCommand.java
src/main/java/fr/xephi/authme/command/executable/authme/ResetNameCommand.java
src/main/java/fr/xephi/authme/command/executable/authme/SetEmailCommand.java
2015-12-12 14:25:01 +01:00