Meishin/LoginSystem
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
2,242 Commits 10 Branches 53 Tags
9b1ee86b2fb737bfd3c27b327d8c85d26fc27f3f
Commit Graph
100 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ljacqu 9b1ee86b2f Trivial code householding 
- Replace `if (!x) ... else ...` with `if(x) ... else ...`
- Avoid throwing RuntimeException; use children
 2016-05-30 12:18:55 +02:00
ljacqu 9349993faf Merge pull request #133 from Gnat008/612-add-PermissionsSystemType-method 
Add isPermissionsSystem method to PermissionsSystemType enum - fixes …
 2016-05-30 07:51:14 +02:00
ljacqu a854d4e0e0 Register entity listener again 2016-05-28 22:29:49 +02:00
ljacqu 25f5fdb45c Code householding (PlayerListener / Settings) 
- Use field on PlayerListener for storing nickname pattern -> repeatedly parsing pattern is expensive
- Remove unused legacy setting fields
- ForceFlatToSqlite cannot be run from converter command -> remove Converter interface to create more natural method signatures
 2016-05-28 22:04:55 +02:00
ljacqu eee06dad50 Dependency graph - allow to summarize dependencies by super type 2016-05-27 23:25:11 +02:00
ljacqu 107441746e Merge remote-tracking branch 'origin/master' 2016-05-27 23:05:40 +02:00
ljacqu cb10854612 Minor - fix failing build (cannot use method from Java 8) 2016-05-27 23:05:03 +02:00
ljacqu 87331d116c Revise converter architecture + add integration test for CrazyLogin converter 2016-05-27 23:00:44 +02:00
ljacqu 67511e3b45 Create task which draws AuthMe dependency graph 2016-05-25 19:24:12 +02:00
ljacqu 3643b88798 #712 Add changes to fr messages by Jeje2201 2016-05-25 17:37:15 +02:00
ljacqu 6341d00df0 Code householding - remove legacy settings and TODO messages 
- Remove fields in legacy settings that are now unused
- Remove various irrelevant todo messages
- Reduce visibility on some elements
 2016-05-24 18:59:01 +02:00
ljacqu e54cd526de Add verification remarks in message files 
- Result from automatic task which checks message files for missing messages or tags
 2016-05-24 18:37:58 +02:00
ljacqu 8de1897412 Minor - Use explicit dependencies in ProcessService 
- Replace AuthMe in favor of PermissionsManager
- Create missing tests for ProcessService
 2016-05-24 18:25:38 +02:00
ljacqu 30f62547d8 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 707-process-as-service 2016-05-23 21:41:41 +02:00
ljacqu 11350ec43a Iterate over all chat recipients 2016-05-22 10:52:34 +02:00
ljacqu 53043ddc0d Create tool task that checks Mock fields of test classes 2016-05-21 11:54:54 +02:00
ljacqu c1885a381b Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 707-process-as-service 
Conflicts:
	src/main/java/fr/xephi/authme/process/join/AsynchronousJoin.java
	src/main/java/fr/xephi/authme/process/login/AsynchronousLogin.java
 2016-05-20 19:48:41 +02:00
ljacqu 3f039d641a #707 Convert sync processes into services 2016-05-20 19:42:30 +02:00
ljacqu 5adf819910 Minor - remove unused services from PurgeCommand 
- Found by sgdc3 in 95b65ae20a
 2016-05-20 18:03:22 +02:00
ljacqu 244e1a2b7d Injector - don't use instantiation fallback if PostConstruct method is present 
- Do not instantiate classes with instantiation fallback if they have a PostConstruct method - thanks @sgdc3 for the hint
- Change Injector test to check exception messages also
 2016-05-20 17:57:14 +02:00
ljacqu a355c325c5 #513 Allow to run updateDocs task from command line 2016-05-20 17:15:53 +02:00
ljacqu 4d634086cd #701 Alternate accounts are shown to all players with their own name 2016-05-19 22:02:15 +02:00
ljacqu 9a72fe53b0 Minor - code householding 
- Update inaccurate javadoc
- Remove unnecessary require call in PHP integration sample
 2016-05-19 21:55:42 +02:00
ljacqu f014485789 Service injector - implement stricter requirements for PostConstruct methods 
- Implement similar restrictions as prescribed by the PostConstruct documentation:
   - Class may have at most one method annotated with PostConstruct
   - PostConstruct method must return void
- Javadoc: replace mentions of injector construction where any injection method was meant
 2016-05-19 21:50:48 +02:00
ljacqu 383820cd22 #702 Implement SHA256 php registration 
- Refactor Bcrypt and Sha256 examples to use common abstract parent class
- Implement hashing logic for Sha256
 2016-05-19 21:44:43 +02:00
ljacqu 14002ee75c #704 Reload settings of ConsoleLogger on /authme reload 2016-05-19 19:46:02 +02:00
ljacqu 92a8a5dd41 #704 Remove reloading from hash algorithms 
- A new instance is created for every hash operation, so reloading will never happen on those classes
 2016-05-18 19:09:38 +02:00
ljacqu f5c89e897f #707 Convert async processes as services 
(work in progress - rough, untested changes)
 2016-05-17 19:49:06 +02:00
ljacqu 3ad76b8ec5 #712 fr messages - add untranslated messages and minor fixes 2016-05-16 17:50:26 +02:00
ljacquandgames647 9f5b995217 Fix datasource resource closing tests (#1) 2016-05-12 20:15:44 +02:00
ljacqu e04f7dc711 #704 Implement reloading via injector 
- Create interfaces Reloadable and SettingsDependent to recognize reloadable classes
- Iterate through instances in injector to reload
 2016-05-12 19:51:10 +02:00
ljacqu 223f56425b #699 Unit test that config.yml values correspond to property defaults 
- Create unit test
- Correct offending values
 2016-05-09 21:15:11 +02:00
ljacqu b728b297b8 #256 Add migration for moved properties 2016-05-08 22:30:53 +02:00
ljacqu f2e49dbf1e Minor - fix compilation of task tool class list 
- Set is declared as ToolTask but all elements extend from AutoToolTask, so the Set type is resolved to a too specific type
 2016-05-08 21:55:08 +02:00
ljacqu 23da023d53 #513 Mark tools runnable by command line with specific interface 2016-05-08 17:22:02 +02:00
ljacqu 662f28ab4f #513 Fix class loading issue when running from mvn exec:java 2016-05-08 17:01:06 +02:00
ljacqu 8e878d6a5a Remove BukkitService from CommandService, inject where needed instead 2016-05-08 13:50:20 +02:00
ljacqu 5e5836f167 #432 Injector improvements 
- Separate FieldInjection from default fallback for no-Inject public no-args constructor classes
- Make CommandInitializer a normal, instantiable service
- Add various injections instead of fetching through command service
 2016-05-08 11:15:56 +02:00
ljacqu 3fe2f0b6a8 Add missing test matcher 
- Mock verifications need matchers on all parameters, or on none. Test fails otherwise
 2016-05-04 18:40:06 +02:00
ljacqu 67aea654cc #432 Fix broken tool tasks 2016-05-03 20:44:01 +02:00
ljacqu 3645806edc Move tools folder into test folder 
- Classes still won't be present in JAR but classes will be automatically compiled by Maven inside of the test scope, facilitating the execution of tool tasks
 2016-05-03 20:27:12 +02:00
ljacqu 23317caa46 Merge pull request #125 from AuthMe-Team/432-dependency-injection 
432 dependency injection
 2016-05-03 18:54:35 +02:00
ljacqu 491dc06de4 Fix RegisterAdminCommand test verifying that online player is kicked 2016-05-02 19:57:54 +02:00
ljacqu f76a68cb26 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-dependency-injection 
Conflicts:
	src/main/java/fr/xephi/authme/AuthMe.java
	src/main/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommand.java
	src/main/java/fr/xephi/authme/hooks/PluginHooks.java
	src/main/java/fr/xephi/authme/listener/AuthMePlayerListener.java
	src/main/java/fr/xephi/authme/listener/AuthMeServerListener.java
	src/test/java/fr/xephi/authme/command/executable/authme/RegisterAdminCommandTest.java
 2016-05-02 19:48:12 +02:00
ljacqu 9af596327a #432 Inject in commands: DataSource / AntiBot / PasswordSecurity / PlayerCache 
- Inject the services instead of passing them through the command service
 2016-05-02 18:52:34 +02:00
ljacqu 1f0f3f1bea #675 Clean up country protection code 
- Move validation to validation service
 2016-04-30 14:11:38 +02:00
ljacqu e6dacd6951 Merge branch 'master' of https://github.com/AuthMe-Team/AuthMeReloaded into 432-dependency-injection 2016-04-30 12:17:33 +02:00
ljacqu 3c6415a6a4 #432 Use injector instantiate hash algorithms 2016-04-30 12:17:18 +02:00
ljacqu 908399e271 #432 Injector - prevent static field injection, add more tests 2016-04-30 10:44:32 +02:00
ljacqu b32e5da4c5 #611 Admin unregister forces player to register even for optional registration 
- Make /authme unregister behave the same way as /unregister for optional registration: user is informed but can continue playing; no teleportation to spawn
 2016-04-30 09:30:52 +02:00
ljacqu 2c491803d3 Injector - disallow static PostConstruct methods, add more tests 2016-04-29 23:49:03 +02:00
ljacqu 7f44ecdb40 Create event consistency test + test code cleanup 2016-04-29 22:39:46 +02:00
ljacqu 8d489efffd #683 Plaintext to SHA256: Add warning message + skip SHA hashes 
- Add message not to stop the server before conversion finishes
- Skip hashes starting with $SHA$ during conversion
- Create unit tests
 2016-04-29 21:58:32 +02:00
ljacqu 077cb242f0 #550 Show welcome message only after login 
- Never send welcome message just after registration (with no subsequent login)
- Always run force command options upon registration
 2016-04-29 21:16:42 +02:00
ljacqu ee08eb9efb Replace Java 1.8 method with 1.7 2016-04-27 23:15:32 +02:00
ljacqu 5963628fa6 #432 Add field injection to AccountsCommand 2016-04-27 22:59:44 +02:00
ljacqu 02079f1f5c #432 Create custom dependency injector 2016-04-27 22:49:20 +02:00
ljacqu 59d3bc95c0 Move getOnlinePlayers() from Utils to BukkitService; delete Wrapper 2016-04-23 15:24:41 +02:00
ljacqu a78e0408c6 #449 Remove use of legacy settings in encryption methods 2016-04-23 12:46:30 +02:00
ljacqu ee745f153d messages_de consistency: Lowercase all occurrences of "du" 2016-04-23 11:06:33 +02:00
ljacqu 63ef8a2597 Merge pull request #124 from EvilOlaf/patch-1 
Minor fixes
 2016-04-23 09:45:43 +02:00
ljacqu 0dab887848 Code householding 
- Various migrations from legacy settings to new settings
- PlayerListener: use shouldCancelEvent() to see if chat should be canceled
- Merge permission manager listener with general server listener
 2016-04-23 00:18:03 +02:00
ljacqu 1182b58b99 Player listener - migrate legacy setting use to new settings 2016-04-22 21:55:25 +02:00
ljacqu 2cd43d599d Minor - MyBB has alphanumerical salts, not restricted to hexadecimal 2016-04-22 21:24:37 +02:00
ljacqu 00cb01b3bd #663 Don't print stacktrace when encountering invalid hash formats 2016-04-21 18:05:47 +02:00
ljacqu e818395575 #667 /authme switchantibot throws NullPointerException 
- Antibot was not provided to CommandService (from where it's retrieved in the SwitchAntiBot command) because it was initialized afterwards
 2016-04-20 21:39:13 +02:00
ljacqu 37fb29f8b9 #638 Register with Wordpress fails with SQL exception 
- Remove semicolon in query, looks like executeBatch() does not like it
 2016-04-20 21:22:57 +02:00
ljacqu 92c476785b Remove generated code / allow import of new languages 
- Exporting back messages to the remote server is now handled by IP whitelisting, not with temporary codes
 2016-04-17 23:17:38 +02:00
ljacqu 354581160a Change export messages task to send updated file to remote server 2016-04-17 12:17:22 +02:00
ljacqu 6c49f5844f Improve saving in messages import 
- Keep same style (messages wrapped in single quotes)
- Remove verification comments and run verification after merge again
 2016-04-16 11:47:18 +02:00
ljacqu f4bc4322f0 Create export/import messages task 
- Allows communication with a web interface (PHP) to translate messages
- Saving via import still needs to be improved
 2016-04-15 23:03:19 +02:00
ljacqu 6c9297a667 #647 Update Hungarian messages 
- By rErEaT
 2016-04-15 15:21:29 +02:00
ljacqu 3674ac087c Code householding + settings migration 
- Migrate and remove unused properties in legacy Settings
- Add forgotten space in Register command
- Fix javadoc errors shown on Jenkins
 2016-04-15 15:17:58 +02:00
ljacqu 71515f188a #551 Email registration should fail if no server email is configured 
- Stop registration and issue an error if the email address setting is empty for email registration
- Refactor register command into smaller portions
- Create tests
 2016-04-15 14:37:47 +02:00
ljacqu 6074ba59d5 #654 Add test verifying nothing is sent for empty message 
- Including various test simplifications
 2016-04-15 12:27:34 +02:00
ljacqu ca0cbe6caf Code householding 
- Move console initialization for tests into TestHelper
- Remove unused properties in legacy Settings
- Add issue number to TODO comments where applicable
 2016-04-14 12:28:19 +02:00
ljacqu 3bb7ff2b85 #653 Empty salt column causes error when retrieving password 
- Handle potentially empty salt column in MySQL and SQLite
- Create unit tests reflecting these cases
 2016-04-14 11:48:24 +02:00
ljacqu b7232d4508 Delete module code 
- Remove code that has been unused for months. If modules come into discussion again it is better to start afresh once requirements are clearer
 2016-04-09 14:55:39 +02:00
ljacqu e2b50b72a5 Get player via BukkitService; add unit tests for commands 2016-04-08 19:56:44 +02:00
ljacqu 83c02f487f Minor - improve previous commit 2016-04-07 17:48:33 +02:00
ljacqu b3a3843b60 Tools: doc templates - add support for iterating tags 
- Support iterating tags
- Generate (update) all docs
 2016-04-07 17:19:52 +02:00
ljacqu 9ea75c502c #567 Move email validation logic to validation service 2016-04-03 20:44:13 +02:00
ljacqu b6ccb3e632 #567 Add/change email should be aware of account threshold 2016-04-03 14:24:12 +02:00
ljacqu c079692f1d Minor - code householding (tests) 
- Remove redundant uses of WrapperMock
- Use assertThat() from JUnit, not hamcrest
- Use hamcrest Matchers everywhere (not BaseMatchers etc.)
- Favor Mockito's argThat() over using ArgumentCaptor (more succinct)
- Delete useless test classes
 2016-04-03 07:38:13 +02:00
ljacqu ba217a2595 Fix disable collisions setting 2016-04-03 07:26:23 +02:00
ljacqu 4f86604699 Check valid password via service 
- Create validation service; fixes same code being duplicated in four places
   - Goal is to remove Utils class, by moving methods to validation service or other services
 - Remove unused properties in legacy settings
 2016-04-02 22:44:20 +02:00
ljacqu 95f5951587 Change message file consistency test to show all errors 2016-03-29 19:08:38 +02:00
ljacqu 55c24b8e64 Test AntiBot + SwitchAntiBotCommand 2016-03-24 22:11:40 +01:00
ljacqu 351b24fd14 Change AntiBot from static to instance 
- Convert static methods in AntiBot
- Create BukkitService for operations requiring calls to static methods on the Bukkit class
 2016-03-24 20:58:51 +01:00
ljacqu 20ad253926 #547 Add javadoc + unit tests for ProcessService 2016-03-21 20:06:49 +01:00
ljacqu f448cb5f9c Merge pull request #120 from AuthMe-Team/603-improve-settings 
603 improve settings
 2016-03-16 21:16:28 +01:00
ljacqu 00c8fa3b53 Minor - remove todo comment 
- Difference between the tests is actually explained in the other class' javadoc
 2016-03-16 21:14:31 +01:00
ljacqu 453f61233c Fix unit tests for settings by providing custom setting migration services 
- Allow to provide custom plugin folder to test constructor
- #603 test all NewSetting methods
 2016-03-16 20:57:41 +01:00
ljacqu aef18a894a Move PropertyType functionality into Property class 2016-03-16 19:07:00 +01:00
ljacqu 89767b120c #603 Pass settings migration service as constructor parameter (work in progress) 2016-03-14 23:18:16 +01:00
ljacqu 4634213d75 #566 Test that all message files are valid YAML 2016-03-14 22:33:20 +01:00
ljacqu 2de3848cc3 #430 Remove PlayerAuth constructors in favor of builder 
- Remove various PlayerAuth constructors
- Clean up FlatFile class
- Add some javadoc to PlayerAuth
 2016-03-14 21:48:33 +01:00
ljacqu ef980bd654 #603 Delete CustomConfiguration class 2016-03-14 20:45:46 +01:00
ljacqu 3522a5b0c0 #603 Various setting improvements 
- Pass PropertyMap to settings class from the outside
- Fix tests not being reentrant due to real file writes
- Improve Node (internal tree for PropertyMap) interface
- Add code coverage for private constructors
 2016-03-14 20:32:32 +01:00
ljacqu 374e2ff292 Fix Management initialization 2016-03-13 11:41:19 +01:00